Adding references to federation docs on left side navigation #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devin-donnelly @jaredbhatti Any idea why http://deploy-preview-1222.kubernetes-io-vnext-staging.netlify.com/docs/api-reference/readme/ and The contents of those 2 files are almost the same. |
|
Why did you add a completely different subdirectory for federation above docs/? I don't think we want to do that. |
|
That is a manifestation of how docs are organised in the core kubernetes repo. |
|
Weird. Okay. |
|
You do have a good point tough. |
nikhiljindal
force-pushed
the
NavLinks
branch
from
d92c864
to
f937f76
Compare
nikhiljindal
force-pushed
the
NavLinks
branch
from
f937f76
to
f72dba5
Compare
nikhiljindal
force-pushed
the
NavLinks
branch
from
f72dba5
to
aaecc8f
Compare
|
@devin-donnelly Updated the PR to move the docs to docs/federation/api-reference instead of federation/docs/api-reference. Not sure why netlify says "Deploy preview failed". When I click on details, it asks me to login and then says "We're working on your site" |
|
According to netlify's build log, there was an error building the site based on your commits: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/57dc71ccc4d9cc64aebd9569 |
|
Here's the error message: |
|
Here's a log from a successful Netlify deployment: |
|
Thanks for those logs @devin-donnelly |
|
Added a commit with an empty sj.yaml file and netlify is able to deploy fine now. |
|
Okay. I'll go ahead and merge. Be aware that we should merge these in the near future, because they aren't in the right place, but they're in the right place for now. |
|
Sorry I didnt understand that. |
2 tasks
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Sep 22, 2022
* Added link to mTLS guide * One more link Co-authored-by: cpretzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977
Ref kubernetes/kubernetes#32612, #1215
cc @kubernetes/sig-cluster-federation
This change is