Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a ref doc for pod security policy #1206

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

pweil-
Copy link
Contributor

@pweil- pweil- commented Sep 12, 2016

@devin-donnelly 1.4 version as requested in #1150 (comment). Updates have been made in both PRs. Thanks!


This change is Reviewable

@devin-donnelly
Copy link
Contributor

Docs LGTM. This does look like it needs a tech review.

1. configMap
1. \* (allow all volumes)

The recommended minimum set of allowed volumes for new SCCs are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/SCC/PSP/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be fixed before merge? I'll mark it as Tech Review: Open Issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is updated now..

@devin-donnelly
Copy link
Contributor

Thanks, merging now.

@devin-donnelly devin-donnelly merged commit f0e8e36 into kubernetes:release-1.4 Sep 14, 2016
@nikhiljindal
Copy link
Contributor

This PR seems to have broken deploy/netlify on release-1.4 branch.

It is failing on all PRs with the following error (Ref #1222 (comment)):

3:27:46 PM: Liquid Exception: Could not locate the included file 'sj.yaml' in any of ["/opt/build/repo/docs/user-guide/pod-security-policy"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. in docs/user-guide/pod-security-policy/index.md
3:27:46 PM: jekyll 3.2.1 | Error: Could not locate the included file 'sj.yaml' in any of ["/opt/build/repo/docs/user-guide/pod-security-policy"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source.
3:27:46 PM: make: *** [build-preview] Error 1

docs/user-guide/pod-security-policy/index.md added in this PR is referring to sj.yaml file that does not exist.

@pweil-
Copy link
Contributor Author

pweil- commented Sep 21, 2016

looking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants