Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PodOverhead feature gate to removed feature gates list #37779

Closed
pacoxu opened this issue Nov 8, 2022 · 12 comments
Closed

Move PodOverhead feature gate to removed feature gates list #37779

pacoxu opened this issue Nov 8, 2022 · 12 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@pacoxu
Copy link
Member

pacoxu commented Nov 8, 2022

@k8s-ci-robot
Copy link
Contributor

@pacoxu: Closing this issue.

In response to this:

   Yes, I think it can. Just two house cleaning items left, pls review if you have time:

(not sure for the process of updating website - like removing the feature gate mention here https://kubernetes.io/docs/concepts/scheduling-eviction/pod-overhead/). But I think it should stay there for longer

/close

Originally posted by @SergeyKanzhelev in kubernetes/enhancements#688 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 8, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Nov 8, 2022

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Contributor

tengqm commented Nov 8, 2022

The concept of 'GA' is different from 'removed'.
For GA'ed gates, we document them at https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/, for removed gates, we use the page https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/

@pacoxu pacoxu changed the title Pod Overhead is removed in v1.26 Pod Overhead is GAed in v1.26 Nov 8, 2022
@pacoxu pacoxu changed the title Pod Overhead is GAed in v1.26 Pod Overhead is removed in v1.26 Nov 8, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Nov 8, 2022

PodOverhead feature gate was removed as the feature is in GA since 1.24

  • GAed in v1.24
  • Removed in v1.26

The title of the PR makes me confused.

https://github.com/kubernetes/website/blob/dev-1.26/content/en/docs/concepts/scheduling-eviction/pod-overhead.md

@sftim
Copy link
Contributor

sftim commented Nov 8, 2022

/sig node
/milestone 1.26

/retitle Move PodOverhead feature gate to removed feature gates list

Does that sound right?

@k8s-ci-robot k8s-ci-robot changed the title Pod Overhead is removed in v1.26 Move PodOverhead feature gate to removed feature gates list Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 8, 2022
@sftim
Copy link
Contributor

sftim commented Nov 8, 2022

@pacoxu
Copy link
Member Author

pacoxu commented Nov 8, 2022

/retitle Move PodOverhead feature gate to removed feature gates list

Does that sound right?

yes

Both https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ and https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/ do need to change.

Got it. Thanks.

@sftim
Copy link
Contributor

sftim commented Nov 13, 2022

/triage accepted

@pacoxu please update the issue description so that a contributor can easily see what needs fixing.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 13, 2022
@Shubham82
Copy link
Contributor

Shubham82 commented Nov 14, 2022

Proposed Solution:
In this we have to move the following things from Feature Gates to Feature Gates (removed):

  1. Move the feature gate PodOverhead from Feature gates for graduated or deprecated features to Feature gates that are removed

  2. Move PodOverhead description und List of feature gates to Descriptions for removed feature gates

@Shubham82
Copy link
Contributor

Hi @pacoxu
This is what we have to do for this issue. Am I right?

@pacoxu
Copy link
Member Author

pacoxu commented Nov 21, 2022

Fixed in #37925.

@pacoxu pacoxu closed this as completed Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants