Pod Overhead: account resources tied to the pod sandbox, but not specific containers

[tallclair]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  Account resources consumed by the pod sandbox, both for scheduling and limiting runtime usage.
• Primary contact (assignee):
  @egernst
• Responsible SIGs:
  /sig node
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20190226-pod-overhead.md
• Design proposal link (community repo):
  WIP: https://docs.google.com/document/d/1EJKT4gyl58-kzt2bnwkv08MIUZ6lkDpXcxkHqCvvAp4/edit?usp=sharing
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which enhancement belongs):
• Enhancement target (which target equals to which milestone):
  • Alpha release target: 1.16
  • Beta release target: 1.18
  • Stable release target: tbd

Relevant K/K issues/PRs for code-freeze::
e2e tests: kubernetes/kubernetes#87215
monitoring: kubernetes/kubernetes#87259
Relevant K/E issues: #1526

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

[tallclair]

/help
I'm looking for someone who is interested in picking back up this proposal. Specifically, the design proposal needs to be reworked in the context of RuntimeClass, and the details need to be worked through with the sig-node community before we can move to implementation.

/cc @egernst

[egernst]

Thanks @tallclair. I may have questions on the process, but am happy to pick this up.

[tallclair]

\o/
/remove-help
/assign @egernst

[k8s-ci-robot]

@tallclair: GitHub didn't allow me to assign the following users: egernst.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

\o/
/remove-help
/assign @egernst

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tallclair]

/assign @egernst

[egernst]

Hey @tallclair et al, I made several suggestions for the WIP RFC @ https://docs.google.com/document/d/1EJKT4gyl58-kzt2bnwkv08MIUZ6lkDpXcxkHqCvvAp4/edit?usp=sharing

I added a section for updating the runtimeClass CRD, and explained how the values would be obtained from the new suggested runtimeClass fields rather than configured in the runtimeController. The suggested runtimeController scope is also greatly reduced, allowing this first iteration to just handle adding the pod overhead.

PTAL.

[vinaykul]

@tallclair @egernst I quickly went though the design proposal. We are working on In-Place Vertical Scaling for Pods, and I want to clarify a couple of things.

In the context or in-place resize, do you see PodSpec.Overhead as something VPA should be aware of via metrics reporting? And perhaps in the future, track this field and make recommendations for it. It would be a good idea to nail down early-on if this field should be mutable by an external entity.

CC: @kgolab @bskiba @schylek

[kacole2]

Hello @tallclair, I'm the Enhancement Lead for 1.15. It looks like there is no KEP accepted yet. Is it safe to assume this will not make the enhancement freeze deadline for 1.15?

[tallclair]

We're still planning on getting this into 1.15. Don't we still have close to 3 weeks to get the KEP in? KEP is here, btw: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20190226-pod-overhead.md

[gracenng]

All good for 1.24 Enhancements Freeze

[nate-double-u]

Hi @egernst 👋 1.24 Docs lead here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, March 31st, 2022 @ 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[gracenng]

Hi @egernst 1.24 Enhancements Team here,
With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, we are currently tracking the following k/k PR:

• mark PodOverhead to GA in v1.24; remove in v1.26 kubernetes#108441

The status of this enhancement is at risk until the PRs are merged. Please let me know if I'm missing any. Thanks!

[valaparthvi]

Hi @SergeyKanzhelev @egernst 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

[gracenng]

Hi @SergeyKanzhelev, is kubernetes/kubernetes#108781 code for this feature as well?
Bumping as we're less than a week from Code Freeze

[gracenng]

All good for 1.24 Code Freeze 🥳

[valaparthvi]

Hi @SergeyKanzhelev @egernst wave 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@SergeyKanzhelev Would you like to add this to the feature blog? I can add it on your behalf if you still do not have the permissions. If you would like to add this to the feature blog, then please add a placeholder PR as well by March 30.

Example of a feature blog PR: kubernetes/website#30538
Example of a feature blog: https://github.com/kubernetes/website/blob/main/content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md

[Priyankasaggu11929]

Hello @SergeyKanzhelev @egernst 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[tallclair]

/lifecycle frozen

@SergeyKanzhelev @egernst Can we close this?

[SergeyKanzhelev]

Yes, I think it can. Just two house cleaning items left, pls review if you have time:

• remove podOverhead feature gate as a feature is now GA since 1.24 kubernetes#112579
• pod overhead is GA'd #3526

(not sure for the process of updating website - like removing the feature gate mention here https://kubernetes.io/docs/concepts/scheduling-eviction/pod-overhead/). But I think it should stay there for longer

/close

[k8s-ci-robot]

@SergeyKanzhelev: Closing this issue.

In response to this:

Yes, I think it can. Just two house cleaning items left, pls review if you have time:

• remove podOverhead feature gate as a feature is now GA since 1.24 kubernetes#112579
• pod overhead is GA'd #3526

(not sure for the process of updating website - like removing the feature gate mention here https://kubernetes.io/docs/concepts/scheduling-eviction/pod-overhead/). But I think it should stay there for longer

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.