Skip to content

Wrap hack/verify-spelling in a bazel test#6760

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
ixdy:verify-spelling-bazel
Feb 9, 2018
Merged

Wrap hack/verify-spelling in a bazel test#6760
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
ixdy:verify-spelling-bazel

Conversation

@ixdy
Copy link
Contributor

@ixdy ixdy commented Feb 9, 2018

Followup to #6716, which turns the new spelling verification check into a bazel test.

This also removes the newly created pull-test-infra-verify-spelling job, since the test would run in the bazel-test job instead.

/cc @dixudx

@k8s-ci-robot k8s-ci-robot requested a review from dixudx February 9, 2018 18:22
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2018
@ixdy ixdy mentioned this pull request Feb 9, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2018

/lgtm
to unblock other PRs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 61fa841 into kubernetes:master Feb 9, 2018
@k8s-ci-robot
Copy link
Contributor

@ixdy: Updated the config configmap

Details

In response to this:

Followup to #6716, which turns the new spelling verification check into a bazel test.

This also removes the newly created pull-test-infra-verify-spelling job, since the test would run in the bazel-test job instead.

/cc @dixudx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dixudx
Copy link
Member

dixudx commented Feb 10, 2018

Thanks @ixdy for making it better.

@ixdy ixdy deleted the verify-spelling-bazel branch May 15, 2018 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants