Skip to content

Comments

Autoscaler VPA recommender e2e tests specified.#6724

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
schylek:master
Feb 13, 2018
Merged

Autoscaler VPA recommender e2e tests specified.#6724
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
schylek:master

Conversation

@schylek
Copy link
Contributor

@schylek schylek commented Feb 8, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Feb 8, 2018

@schylek you should use --test-cmd=foo, and --test-cmd-args=bar and point to your repo, instead of making a new flag in kubetest which is too specific.

/assign

@schylek
Copy link
Contributor Author

schylek commented Feb 9, 2018

I was following perfTest flag example. In such case does perfTests needs a dedicated flag?
Refinements applied.

/assign @krzyzacy

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2018

@schylek yeah we are going to bikeshed perfTest into --test-cmd as well - they are basically doing the same thing

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, schylek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2018

./hack/verify-spelling.sh is not executable? cc @ixdy @BenTheElder

@ixdy
Copy link
Contributor

ixdy commented Feb 9, 2018

yeah, I have #6760 to fix that.

@ixdy
Copy link
Contributor

ixdy commented Feb 9, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 13, 2018

@schylek: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-test-infra-verify-spelling 068b416 link /test pull-test-infra-verify-spelling

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schylek
Copy link
Contributor Author

schylek commented Feb 13, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 51a132b into kubernetes:master Feb 13, 2018
@k8s-ci-robot
Copy link
Contributor

@schylek: Updated the config configmap

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants