Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci-kubernetes-e2e-gce-min-node-permissions #4685

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Add ci-kubernetes-e2e-gce-min-node-permissions #4685

merged 1 commit into from
Sep 28, 2017

Conversation

ikehz
Copy link
Contributor

@ikehz ikehz commented Sep 21, 2017

... to test granting minimal node permissions

Xref kubernetes/kubernetes#52868

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2017
krzyzacy
krzyzacy reviewed Sep 21, 2017
View reviewed changes
jobs/config.json
"--env-file=jobs/platform/gce.env",
"--env-file=jobs/env/ci-kubernetes-e2e-gce-min-node-permissions.env",
"--extract=ci/latest",
"--gcp-project=k8s-min-node-permissions",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this project has some special quota/IAM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has the min-node-permissions@k8s-min-node-permissions.iam.gserviceaccount.com service account configured.

krzyzacy
krzyzacy reviewed Sep 21, 2017
View reviewed changes
jobs/config.json Outdated
],
"scenario": "kubernetes_e2e",
"sigOwners": [
"UNKNOWN"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put a sig here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ikehz
Copy link
Contributor Author

ikehz commented Sep 22, 2017

Ptal.

krzyzacy
krzyzacy reviewed Sep 22, 2017
View reviewed changes
testgrid/config/config.yaml
@@ -1995,6 +1995,8 @@ dashboards:
test_group_name: ci-kubernetes-e2e-gce-device-plugin-gpu
- name: gce-gpu
test_group_name: ci-kubernetes-e2e-gce-gpu
- name: gce-min-node-permissions
test_group_name: ci-kubernetes-e2e-gce-min-node-permissions
Copy link
Member

@krzyzacy krzyzacy Sep 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to add something similar to https://github.com/ihmccreery/test-infra/blob/21a4014b4bd783ce58a7c93dee03a42624692bf6/testgrid/config/config.yaml#L1735-L1736 for the new job, and you should be good to go.

(that's what the travis failure tries to tell you)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@krzyzacy
Copy link
Member

(and please run bazel run //jobs:config_sort to keep the config sorted)

@ikehz ikehz force-pushed the min-node-permissions branch from 21a4014 to e6c0168 Compare September 28, 2017 17:04
@ikehz
Copy link
Contributor Author

ikehz commented Sep 28, 2017

(and please run bazel run //jobs:config_sort to keep the config sorted)

Done.

@ikehz ikehz force-pushed the min-node-permissions branch from e6c0168 to 8f89139 Compare September 28, 2017 17:06
krzyzacy
krzyzacy reviewed Sep 28, 2017
View reviewed changes
testgrid/config/config.yaml Outdated
@@ -1758,6 +1758,8 @@ test_groups:
gcs_prefix: kubernetes-jenkins/logs/ci-kubernetes-e2e-gke-gci-stable1-gci-stable2-downgrade-cluster
- name: ci-kubernetes-e2e-gke-gci-stable1-gci-stable2-downgrade-cluster-parallel
gcs_prefix: kubernetes-jenkins/logs/ci-kubernetes-e2e-gke-gci-stable1-gci-stable2-downgrade-cluster-parallel
- name: gce-min-node-permissions
gcs_prefix: kubernetes-jenkins/logs/gce-min-node-permissions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/gce-min-node-permissions/ci-kubernetes-e2e-gce-min-node-permissions/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ikehz ikehz force-pushed the min-node-permissions branch from 8f89139 to 5dc30d2 Compare September 28, 2017 17:14
@krzyzacy
Copy link
Member

(seems prow/config.yaml is still not sorted properly - LGTM once all presubmit passes)

@ikehz ikehz force-pushed the min-node-permissions branch 2 times, most recently from 2dbda5d to e63f0c9 Compare September 28, 2017 17:19
krzyzacy
krzyzacy reviewed Sep 28, 2017
View reviewed changes
testgrid/config/config.yaml Outdated
@@ -1758,6 +1758,8 @@ test_groups:
gcs_prefix: kubernetes-jenkins/logs/ci-kubernetes-e2e-gke-gci-stable1-gci-stable2-downgrade-cluster
- name: ci-kubernetes-e2e-gke-gci-stable1-gci-stable2-downgrade-cluster-parallel
gcs_prefix: kubernetes-jenkins/logs/ci-kubernetes-e2e-gke-gci-stable1-gci-stable2-downgrade-cluster-parallel
- name: ci-kubernetes-e2e-gce-gce-min-node-permissions
gcs_prefix: kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-gce-min-node-permissions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one less -gce 😈

@ikehz ikehz force-pushed the min-node-permissions branch from e63f0c9 to e547807 Compare September 28, 2017 18:01
@ikehz
Copy link
Contributor Author

ikehz commented Sep 28, 2017

sigh Okay @krzyzacy ptal.

@krzyzacy
Copy link
Member

/shrug
/lgtm

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Sep 28, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2017
@krzyzacy krzyzacy merged commit 7b623ea into kubernetes:master Sep 28, 2017
@k8s-ci-robot
Copy link
Contributor

@ihmccreery: I updated Prow config for you!

In response to this:

... to test granting minimal node permissions

Xref kubernetes/kubernetes#52868

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ikehz
Copy link
Contributor Author

ikehz commented Sep 29, 2017

Thanks @krzyzacy. When can I expect this to show up on the dashboards?

@krzyzacy
Copy link
Member

@ihmccreery http://k8s-testgrid.appspot.com/google-gce#gce-min-node-permissions

@spiffxp spiffxp mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy left review comments

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@krzyzacy krzyzacy

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikehz @krzyzacy @k8s-ci-robot