Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ci-kubernetes-e2e-gce-min-node-permissions #17156

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Remove ci-kubernetes-e2e-gce-min-node-permissions #17156

merged 1 commit into from
Apr 8, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Apr 8, 2020

It has never passed in 923 days since it first ran on 2017-09-28

@spiffxp
Remove ci-kubernetes-e2e-gce-min-node-permissions
424ccae 
It has never passed in 923 days since it first ran on 2017-09-28
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 8, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Apr 8, 2020

Took a while to track down, it was added via #4685

@spiffxp
Copy link
Member Author

spiffxp commented Apr 8, 2020

/assign @ihmccreery

@ikehz
Copy link
Contributor

ikehz commented Apr 8, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 70d3616 into kubernetes:master Apr 8, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key gce-misc.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gce-misc.yaml

In response to this:

It has never passed in 923 days since it first ran on 2017-09-28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the rm-min-node-permissions branch April 8, 2020 23:32
@spiffxp spiffxp mentioned this pull request Apr 10, 2020
Closed
@spiffxp spiffxp mentioned this pull request Jun 17, 2021
Open
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@hogepodge hogepodge Awaiting requested review from hogepodge

Assignees

@ikehz ikehz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @ikehz