Skip to content

Ensure windows nodes provision for pull-cluster-api-provider-azure-ci-entrypoint jobs #25082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Feb 2, 2022
Merged

Ensure windows nodes provision for pull-cluster-api-provider-azure-ci-entrypoint jobs #25082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,9 @@ presubmits:
# docker-in-docker needs privileged mode
securityContext:
privileged: true
env:
- name: TEST_WINDOWS
value: "true"
annotations:
testgrid-dashboards: sig-cluster-lifecycle-cluster-api-provider-azure
testgrid-tab-name: capz-pr-ci-entrypoint-main
Expand Down
3 changes: 3 additions & 0 deletions ...igs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,9 @@ presubmits:
# docker-in-docker needs privileged mode
securityContext:
privileged: true
env:
- name: TEST_WINDOWS
Copy link
Copy Markdown
Member

@CecileRobertMichon CecileRobertMichon Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requires k8s 1.22+, are we testing with 1.22 in the release-1.1 branch?

Copy link
Copy Markdown
Contributor Author

@marosset marosset Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it
From the pull-cluster-api-provider-azure-ci-entrypoint-v1beta job on kubernetes-sigs/cluster-api-provider-azure#2027

NAME                              STATUS   ROLES                  AGE     VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION     CONTAINER-RUNTIME
capz-uwrg2l-control-plane-qtbvc   Ready    control-plane,master   2m10s   v1.22.1   10.0.0.4      <none>        Ubuntu 20.04.3 LTS   5.8.0-1039-azure   containerd://1.5.4
capz-uwrg2l-md-0-thklx            Ready    <none>                 52s     v1.22.1   10.1.0.4      <none>        Ubuntu 20.04.3 LTS   5.8.0-1039-azure   containerd://1.5.4
capz-uwrg2l-md-0-wmdnh            Ready    <none>                 31s     v1.22.1   10.1.0.5      <none>        Ubuntu 20.04.3 LTS   5.8.0-1039-azure   containerd://1.5.4

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/2027/pull-cluster-api-provider-azure-ci-entrypoint-v1beta1/1488575602268049408

Copy link
Copy Markdown
Contributor

@jsturtevant jsturtevant Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. doesn't look like it https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/61fcf75d5a290577be64604db363baf6b5e604bb/hack/create-dev-cluster.sh#L50

i read that wrong. that line does say v1.22.1

value: "true"
annotations:
testgrid-dashboards: sig-cluster-lifecycle-cluster-api-provider-azure
testgrid-tab-name: capz-pr-ci-entrypoint-v1beta1
Expand Down