Skip to content

Ensure windows nodes provision for pull-cluster-api-provider-azure-ci-entrypoint jobs#25082

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
marosset:capz-ci-entrypoint-windows-nodes
Feb 2, 2022
Merged

Ensure windows nodes provision for pull-cluster-api-provider-azure-ci-entrypoint jobs#25082
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
marosset:capz-ci-entrypoint-windows-nodes

Conversation

@marosset
Copy link
Copy Markdown
Contributor

@marosset marosset commented Feb 1, 2022

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2022
@marosset
Copy link
Copy Markdown
Contributor Author

marosset commented Feb 1, 2022

/assign @jsturtevant @CecileRobertMichon

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 1, 2022
@jsturtevant
Copy link
Copy Markdown
Contributor

jsturtevant commented Feb 1, 2022

this will allow us to make sure the provisioning works for windows as well
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@jsturtevant
Copy link
Copy Markdown
Contributor

jsturtevant commented Feb 1, 2022

/cancel lgtm
I forgot that pull-cluster-api-provider-azure-ci-entrypoint-v1alpha4 is running against - ^release-0.5$ branch which doesn't have containerd support

jsturtevant
jsturtevant reviewed Feb 1, 2022
View reviewed changes
Comment thread ...-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-v1alpha4.yaml Outdated
securityContext:
privileged: true
env:
- name: TEST_WINDOWS
Copy link
Copy Markdown
Contributor

@jsturtevant jsturtevant Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is running against - ^release-0.5$ which doesn't have containerd support. I don't think the script would do anything with this but probably shouldn't include it

@marosset
Copy link
Copy Markdown
Contributor Author

marosset commented Feb 1, 2022

/cancel lgtm I forgot that pull-cluster-api-provider-azure-ci-entrypoint-v1alpha4 is running against - ^release-0.5$ branch which doesn't have containerd support

Ahh, i was just checking on that now.
beta.1 has containerd support tho - correct?

@marosset
Ensure windows nodes provision for pull-cluster-api-provider-azure-ci…
baffa43 
…-entrypoint jobs

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@marosset marosset force-pushed the capz-ci-entrypoint-windows-nodes branch from b2d4d22 to baffa43 Compare February 1, 2022 23:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@marosset
Copy link
Copy Markdown
Contributor Author

marosset commented Feb 1, 2022

I reverted the v1alpha4 changes.

CecileRobertMichon
CecileRobertMichon reviewed Feb 1, 2022
View reviewed changes
Comment thread ...s-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-v1beta1.yaml
securityContext:
privileged: true
env:
- name: TEST_WINDOWS
Copy link
Copy Markdown
Member

@CecileRobertMichon CecileRobertMichon Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requires k8s 1.22+, are we testing with 1.22 in the release-1.1 branch?

Copy link
Copy Markdown
Contributor Author

@marosset marosset Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it
From the pull-cluster-api-provider-azure-ci-entrypoint-v1beta job on kubernetes-sigs/cluster-api-provider-azure#2027

NAME                              STATUS   ROLES                  AGE     VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION     CONTAINER-RUNTIME
capz-uwrg2l-control-plane-qtbvc   Ready    control-plane,master   2m10s   v1.22.1   10.0.0.4      <none>        Ubuntu 20.04.3 LTS   5.8.0-1039-azure   containerd://1.5.4
capz-uwrg2l-md-0-thklx            Ready    <none>                 52s     v1.22.1   10.1.0.4      <none>        Ubuntu 20.04.3 LTS   5.8.0-1039-azure   containerd://1.5.4
capz-uwrg2l-md-0-wmdnh            Ready    <none>                 31s     v1.22.1   10.1.0.5      <none>        Ubuntu 20.04.3 LTS   5.8.0-1039-azure   containerd://1.5.4

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/2027/pull-cluster-api-provider-azure-ci-entrypoint-v1beta1/1488575602268049408

Copy link
Copy Markdown
Contributor

@jsturtevant jsturtevant Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. doesn't look like it https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/61fcf75d5a290577be64604db363baf6b5e604bb/hack/create-dev-cluster.sh#L50

i read that wrong. that line does say v1.22.1

@jsturtevant
Copy link
Copy Markdown
Contributor

jsturtevant commented Feb 1, 2022

the v1beta is running against the 1.* release branches which does have containerd support

@CecileRobertMichon
Copy link
Copy Markdown
Member

CecileRobertMichon commented Feb 2, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0d92735 into kubernetes:master Feb 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 2, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 2, 2022

@marosset: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
  • key cluster-api-provider-azure-presubmits-release-v1beta1.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-v1beta1.yaml
Details

In response to this:

Signed-off-by: Mark Rossetti marosset@microsoft.com

Setting TEST_WINDOWS will provision 2 Windows nodes in the workload cluster

https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/7979a9705adabde2085801b04f87ad00e8888e1e/scripts/ci-entrypoint.sh#L104-L107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset marosset deleted the capz-ci-entrypoint-windows-nodes branch February 2, 2022 18:32
@marosset marosset mentioned this pull request Feb 2, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma Awaiting requested review from mboersma

@shysank shysank Awaiting requested review from shysank

2 more reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jsturtevant jsturtevant

@CecileRobertMichon CecileRobertMichon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.24

Development

Successfully merging this pull request may close these issues.

4 participants

@marosset @jsturtevant @CecileRobertMichon @k8s-ci-robot