Skip to content

wg-k8s-infra: add pull-k8s.io-verify job#21214

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nikhita:pull-k8s-io-verify
Mar 9, 2021
Merged

wg-k8s-infra: add pull-k8s.io-verify job#21214
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nikhita:pull-k8s-io-verify

Conversation

@nikhita
Copy link
Member

@nikhita nikhita commented Mar 7, 2021

For kubernetes/k8s.io#1765

/hold
this should not merge until kubernetes/k8s.io#1765 has merged

/assign @spiffxp

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Mar 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp March 7, 2021 16:01
Copy link
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
Let's find out if status reconciler does it's thing for the rename here

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@spiffxp
Copy link
Contributor

spiffxp commented Mar 9, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 43e3f37 into kubernetes:master Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

@nikhita: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8sio-presubmit.yaml using file config/jobs/kubernetes/wg-k8s-infra/k8sio-presubmit.yaml
Details

In response to this:

For kubernetes/k8s.io#1765

/hold
this should not merge until kubernetes/k8s.io#1765 has merged

/assign @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Contributor

spiffxp commented Mar 9, 2021

@nikhita @ameukam doh, this broke merges to k8s.io since verify-terraform expects a cluster. A followup PR to exclude it by default here is probably quickest way to unblock

@nikhita
Copy link
Member Author

nikhita commented Mar 9, 2021

doh, this broke merges to k8s.io since verify-terraform expects a cluster.

the job is green on other PRs 😄
it's probably only broken for kubernetes/k8s.io#1732

A followup PR to exclude it by default here is probably quickest way to unblock

kubernetes/k8s.io#1770 (thanks @ameukam)

@nikhita nikhita deleted the pull-k8s-io-verify branch March 9, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants