Add script validation for Terraform

[ameukam]

Download terraform and validate Terraform configuration for
a given path assuming terraform files are presen in this path.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

[ameukam]

The presubmit job will have a command like:

hack/verify-terraform.sh infra/gcp/clusters/projects/k8s-infra-prow-build/prow-build

[ameukam]

/hold
/assign @spiffxp
cc @BenTheElder @thockin

[spiffxp]

I'd rather this work on my laptop too.

I think a version check and erroring out if it doesn't exist/match would be a good start. Let the developer work out how to get the correct version, and assume when this runs in a container it will have the correct version already installed

Handy for managing locally, maybe useful to allow CI to auto-install / switch:

• tfenv + .terraform-version files fit a pattern I know , but it's lots of bash
• tfswitch uses version.tf files which could be another option

[ameukam]

I'll go for tfswitch since it supports version.tf.

[nikhita]

/test pull-k8sio-verify

[nikhita]

For the record - verify-terraform.sh was excluded in #1770 so pull-k8sio-verify does not run this script.

[spiffxp]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ameukam]

/remove hold

[ameukam]

/remove hold

[ameukam]

/unhold