Skip to content

jobs: tell pull-k8sio-yamllint what files to lint#20962

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
spiffxp:k8sio-yamllint-where
Feb 23, 2021
Merged

jobs: tell pull-k8sio-yamllint what files to lint#20962
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
spiffxp:k8sio-yamllint-where

Conversation

@spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Feb 23, 2021

Followup to #20956, which has now blocked all PRs to that repo whoops

This is what I get for not just straight up calling the hack/verify-yamllint.sh script... but it relies on bash, which is not in this job's container

/assign @nikhita

this is what I get for not just straight up calling the
hack/verify-yamllint.sh script... but it relies on bash,
which is not in this job's container
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@ameukam
Copy link
Member

ameukam commented Feb 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 952586a into kubernetes:master Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8sio-presubmit.yaml using file config/jobs/kubernetes/wg-k8s-infra/k8sio-presubmit.yaml
Details

In response to this:

Followup to #20956, which has now blocked all PRs to that repo whoops

This is what I get for not just straight up calling the hack/verify-yamllint.sh script... but it relies on bash, which is not in this job's container

/assign @nikhita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the k8sio-yamllint-where branch February 23, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants