Skip to content

Add pull-k8sio-yamllint#20956

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
spiffxp:pull-k8sio-yamllint
Feb 23, 2021
Merged

Add pull-k8sio-yamllint#20956
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
spiffxp:pull-k8sio-yamllint

Conversation

@spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Feb 23, 2021

Based off of test-infra-yamllint job

/hold
Needs kubernetes/k8s.io#1694 to merge first

I realized we have a lot of yaml in kubernetes/k8s.io, and there is really
not much in the way of presubmit validation. This is a really bare-bones
start.

Ideas for followup if anyone is interested:

  • use a non-quay.io image and call hack/verify-yamllint.sh instead
  • move toward a pull-k8sio-verify job that calls hack/verify-* similar to
    kubernetes/kubernetes
  • add boilerplate check to that job

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2021
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims February 23, 2021 01:46
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2021
Based off of test-infra-yamllint job
@spiffxp spiffxp force-pushed the pull-k8sio-yamllint branch from 49c51ca to 4385fa6 Compare February 23, 2021 04:18
@spiffxp
Copy link
Contributor Author

spiffxp commented Feb 23, 2021

/hold cancel
kubernetes/k8s.io#1694 merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bfc7236 into kubernetes:master Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8sio-presubmit.yaml using file config/jobs/kubernetes/wg-k8s-infra/k8sio-presubmit.yaml
Details

In response to this:

Based off of test-infra-yamllint job

/hold
Needs kubernetes/k8s.io#1694 to merge first

I realized we have a lot of yaml in kubernetes/k8s.io, and there is really
not much in the way of presubmit validation. This is a really bare-bones
start.

Ideas for followup if anyone is interested:

  • use a non-quay.io image and call hack/verify-yamllint.sh instead
  • move toward a pull-k8sio-verify job that calls hack/verify-* similar to
    kubernetes/kubernetes
  • add boilerplate check to that job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita
Copy link
Member

nikhita commented Feb 23, 2021

@nikhita
Copy link
Member

nikhita commented Feb 23, 2021

Looks like we miss the args to specify the directories where this should run..can create a PR to fix this after a couple of hours.

@spiffxp
Copy link
Contributor Author

spiffxp commented Feb 23, 2021

@nikhita my bad! opened #20962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants