Support for Image Builder - AWS sub-accounts by kkeshavamurthy · Pull Request #19645 · kubernetes/test-infra

kkeshavamurthy · 2020-10-21T17:27:48Z

PR for Issue #19630

I was not sure if there were any naming convention used for boskos resource types, so picked the most descriptive one.

k8s-ci-robot · 2020-10-21T17:27:56Z

Welcome @kkeshavamurthy!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-10-21T17:27:56Z

Hi @kkeshavamurthy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

detiber

Minor nit around the naming (account vs project) since boskos would be providing account credentials rather than a project, which is a GCP concept.

config/prow/cluster/boskos-janitor.yaml

config/prow/cluster/boskos-reaper_deployment.yaml

config/prow/cluster/boskos-resources.yaml

config/prow/cluster/monitoring/mixins/lib/config.libsonnet

detiber · 2020-10-21T17:52:10Z

/ok-to-test

kkeshavamurthy · 2020-10-21T18:09:20Z

Thanks @detiber. Done.

config/prow/cluster/monitoring/mixins/lib/config.libsonnet

detiber · 2020-10-23T14:52:07Z

/hold
blocked on kubernetes-sigs/boskos#43
Also blocked on the secrets being created/loaded

k8s-ci-robot · 2020-10-29T19:58:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, kkeshavamurthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~config/prow/cluster/OWNERS~~ [fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codenrhoden · 2020-11-05T16:24:17Z

@detiber Looks like the hold here can be lifted? With than and a new LGTM should be good to go.

detiber · 2020-11-05T16:28:43Z

@codenrhoden Yes, the boskos changes have already been made. I'm not sure about the actual account creation and the creation of the secrets, though. It is possible that those could still be blockers.

fejta-bot · 2021-02-03T17:15:13Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2021-03-05T18:01:29Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

kkeshavamurthy · 2021-03-07T11:31:01Z

/remove-lifecycle rotten

spiffxp · 2021-03-09T01:50:13Z

Have had priorities elsewhere, and still do for the next few days. Ping wg-k8s-infra on slack or add to next meeting agenda if still blocked by that time

fejta · 2021-03-09T22:38:01Z

/uncc
/cc @spiffxp

kkeshavamurthy · 2021-03-10T07:45:20Z

@dims can you please help with this?

CC: @codenrhoden

dims · 2021-04-04T23:45:42Z

@kkeshavamurthy please take this to the k8s infra wg meeting like @spiffxp mentioned above.

fejta-bot · 2021-07-03T23:53:50Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

k8s-triage-robot · 2021-08-03T00:40:54Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

k8s-triage-robot · 2021-09-02T00:44:45Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2021-09-02T00:44:57Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 21, 2020

k8s-ci-robot requested review from cblecker, chases2 and hongkailiu October 21, 2020 17:28

kkeshavamurthy changed the title ~~Support for Image Builder - AWS sub-accounts~~ [WIP] Support for Image Builder - AWS sub-accounts Oct 21, 2020

detiber reviewed Oct 21, 2020

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2020

kkeshavamurthy force-pushed the image-builder-aws-project branch from da163c0 to dc1e520 Compare October 21, 2020 18:07

detiber reviewed Oct 21, 2020

View reviewed changes

config/prow/cluster/monitoring/mixins/lib/config.libsonnet Outdated Show resolved Hide resolved

kkeshavamurthy mentioned this pull request Oct 22, 2020

support boskos resource of type image-builder-aws-account kubernetes-sigs/boskos#43

Merged

kkeshavamurthy force-pushed the image-builder-aws-project branch 2 times, most recently from 50d8d65 to 732260d Compare October 23, 2020 00:17

kkeshavamurthy changed the title ~~[WIP] Support for Image Builder - AWS sub-accounts~~ Support for Image Builder - AWS sub-accounts Oct 23, 2020

kkeshavamurthy marked this pull request as ready for review October 23, 2020 00:18

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2020

chases2 requested review from fejta and removed request for chases2 October 23, 2020 21:20

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020

k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 3, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 5, 2021

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 7, 2021

kkeshavamurthy force-pushed the image-builder-aws-project branch from 732260d to f94ec9e Compare March 7, 2021 11:44

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021

Support for Image Builder - AWS sub-accounts

5eaef90

kkeshavamurthy force-pushed the image-builder-aws-project branch from f94ec9e to 5eaef90 Compare March 7, 2021 11:45

k8s-ci-robot requested review from spiffxp and removed request for fejta March 9, 2021 22:38

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2021

k8s-ci-robot closed this Sep 2, 2021

Conversation

kkeshavamurthy commented Oct 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 21, 2020

Uh oh!

k8s-ci-robot commented Oct 21, 2020

Uh oh!

detiber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

detiber commented Oct 21, 2020

Uh oh!

kkeshavamurthy commented Oct 21, 2020

Uh oh!

Uh oh!

detiber commented Oct 23, 2020

Uh oh!

k8s-ci-robot commented Oct 29, 2020

Uh oh!

codenrhoden commented Nov 5, 2020

Uh oh!

detiber commented Nov 5, 2020

Uh oh!

fejta-bot commented Feb 3, 2021

Uh oh!

fejta-bot commented Mar 5, 2021

Uh oh!

kkeshavamurthy commented Mar 7, 2021

Uh oh!

spiffxp commented Mar 9, 2021

Uh oh!

fejta commented Mar 9, 2021

Uh oh!

kkeshavamurthy commented Mar 10, 2021

Uh oh!

dims commented Apr 4, 2021

Uh oh!

fejta-bot commented Jul 3, 2021

Uh oh!

k8s-triage-robot commented Aug 3, 2021

Uh oh!

k8s-triage-robot commented Sep 2, 2021

Uh oh!

k8s-ci-robot commented Sep 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

kkeshavamurthy commented Oct 21, 2020 •

edited

Loading