Skip to content

support boskos resource of type image-builder-aws-account#43

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
kkeshavamurthy:image-builder-support
Oct 29, 2020
Merged

support boskos resource of type image-builder-aws-account#43
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
kkeshavamurthy:image-builder-support

Conversation

@kkeshavamurthy
Copy link
Copy Markdown
Member

@kkeshavamurthy kkeshavamurthy commented Oct 22, 2020

Changes related to utilizing boskos for image-builder CI,
kubernetes/test-infra#19645

Please let me know if I have missed anything.
CC: @detiber

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 22, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 22, 2020

Welcome @kkeshavamurthy!

It looks like this is your first PR to kubernetes-sigs/boskos 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/boskos has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 22, 2020

Hi @kkeshavamurthy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2020
ixdy
ixdy suggested changes Oct 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ixdy ixdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2020
@kkeshavamurthy kkeshavamurthy changed the title [WIP] support boskos resource of type image-builder-aws-account support boskos resource of type image-builder-aws-account Oct 23, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2020
detiber
detiber reviewed Oct 23, 2020
View reviewed changes
@detiber detiber mentioned this pull request Oct 23, 2020
Closed
ixdy
ixdy reviewed Oct 23, 2020
View reviewed changes
ixdy
ixdy reviewed Oct 27, 2020
View reviewed changes
ixdy
ixdy approved these changes Oct 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ixdy ixdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@detiber did you have any additional comments?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 27, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, kkeshavamurthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
This was referenced Oct 27, 2020
Closed
Closed
@detiber
Copy link
Copy Markdown
Contributor

detiber commented Oct 29, 2020

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 05fda33 into kubernetes-sigs:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb Awaiting requested review from justinsb

2 more reviewers

@detiber detiber detiber left review comments

@ixdy ixdy ixdy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@detiber detiber

@ixdy ixdy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kkeshavamurthy @k8s-ci-robot @detiber @ixdy