Skip to content

Add image-pushing job for capo#14246

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
sbueringer:pr-add-capo-image-pushing-job
Sep 11, 2019
Merged

Add image-pushing job for capo#14246
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
sbueringer:pr-add-capo-image-pushing-job

Conversation

@sbueringer
Copy link
Member

This PR adds a job to push CAPO images similar to the CAPI ones: #14195

Hope this PR is not to wrong. I'mt not sure what the correct process is or if there's anything else to do :)

/cc @Katharine @detiber

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sbueringer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 9, 2019
@sbueringer
Copy link
Member Author

/assign @Katharine

@Katharine
Copy link
Member

Katharine commented Sep 9, 2019

This looks correct to me.

You'll want kubernetes-sigs/cluster-api-provider-openstack#460 in first. That PR looks plausible but I can't really review because I don't know how your build process works - that part is repo specific. GCB does provide instructions for testing on your machine which might be helpful to you.

You'll also need a scratch bucket created and permissions to be set up on your staging GCR, which should happen once kubernetes/k8s.io#356 merges and is run by someone (assuming @thockin didn't do something already).

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2019
@detiber
Copy link
Contributor

detiber commented Sep 9, 2019

@sbueringer might want to incorporate similar changes as this PR as well: https://github.com/kubernetes/test-infra/pull/14228/files

@sbueringer
Copy link
Member Author

@Katharine Thx. I verified the job locally, worked perfect. So I make sure to get the PR in CAPO merged and wait until the other one from @thockin.

@sbueringer
Copy link
Member Author

sbueringer commented Sep 9, 2019

@sbueringer might want to incorporate similar changes as this PR as well: https://github.com/kubernetes/test-infra/pull/14228/files

Thx I saw the update in CAPI but missed this one here :)
I adjusted the file here.

@Katharine
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2019
Co-Authored-By: Katharine Berry <ktbry@google.com>
@sbueringer
Copy link
Member Author

@Katharine thx :), fixed

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 5e0481fd672436e79fbfce68633e478ae9daaf01

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@Katharine
Copy link
Member

Feel free to unhold when relevant changes have landed in your repo.

@sbueringer
Copy link
Member Author

Feel free to unhold when relevant changes have landed in your repo.

Changes have been merged to the CAPO repo. Basically the same as in the CAPI repo, so I guess it should work :)

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit fb5e470 into kubernetes:master Sep 11, 2019
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default using the following files:

  • key k8s-staging-capi-openstack.yaml using file config/jobs/image-pushing/k8s-staging-capi-openstack.yaml
Details

In response to this:

This PR adds a job to push CAPO images similar to the CAPI ones: #14195

Hope this PR is not to wrong. I'mt not sure what the correct process is or if there's anything else to do :)

/cc @Katharine @detiber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 11, 2019
@sbueringer sbueringer deleted the pr-add-capo-image-pushing-job branch September 11, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants