Add image-pushing job for capo#14246
Conversation
|
Hi @sbueringer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @Katharine |
|
This looks correct to me. You'll want kubernetes-sigs/cluster-api-provider-openstack#460 in first. That PR looks plausible but I can't really review because I don't know how your build process works - that part is repo specific. GCB does provide instructions for testing on your machine which might be helpful to you. You'll also need a scratch bucket created and permissions to be set up on your staging GCR, which should happen once kubernetes/k8s.io#356 merges and is run by someone (assuming @thockin didn't do something already). /hold |
|
@sbueringer might want to incorporate similar changes as this PR as well: https://github.com/kubernetes/test-infra/pull/14228/files |
|
@Katharine Thx. I verified the job locally, worked perfect. So I make sure to get the PR in CAPO merged and wait until the other one from @thockin. |
Thx I saw the update in CAPI but missed this one here :) |
|
/ok-to-test |
Co-Authored-By: Katharine Berry <ktbry@google.com>
|
@Katharine thx :), fixed |
|
LGTM label has been added. DetailsGit tree hash: 5e0481fd672436e79fbfce68633e478ae9daaf01 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Katharine, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Feel free to unhold when relevant changes have landed in your repo. |
Changes have been merged to the CAPO repo. Basically the same as in the CAPI repo, so I guess it should work :) /hold cancel |
|
@sbueringer: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds a job to push CAPO images similar to the CAPI ones: #14195
Hope this PR is not to wrong. I'mt not sure what the correct process is or if there's anything else to do :)
/cc @Katharine @detiber