Skip to content

Add a job to build/push images from kubernetes-sigs/cluster-api#14195

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Katharine:gcb-poc
Sep 6, 2019
Merged

Add a job to build/push images from kubernetes-sigs/cluster-api#14195
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Katharine:gcb-poc

Conversation

@Katharine
Copy link
Member

@Katharine Katharine commented Sep 4, 2019

This adds a job for kubernetes-sigs/cluster-api to push images using some cloudbuild.yaml file in that repo.

/cc @Katharine

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 4, 2019

@Katharine: GitHub didn't allow me to request PR reviews from the following users: Katharine.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

This adds a job for kubernetes-sigs/cluster-api to push images using some cloudbuild.yaml file in that repo.

/cc @Katharine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 4, 2019
@Katharine Katharine force-pushed the gcb-poc branch 2 times, most recently from d6d9961 to ced990c Compare September 4, 2019 17:47
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2019
@Katharine
Copy link
Member Author

Katharine commented Sep 4, 2019

/retest

@detiber detiber mentioned this pull request Sep 6, 2019
Merged
@Katharine Katharine changed the title [WIP] Add a job to build/push images from kubernetes-sigs/cluster-api Add a job to build/push images from kubernetes-sigs/cluster-api Sep 6, 2019
@Katharine Katharine marked this pull request as ready for review September 6, 2019 15:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2019
vincepri
vincepri approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 6, 2019

LGTM label has been added.

DetailsGit tree hash: b12934d761cd16ab4cdab6a482b1f2fc8ca2e2b7

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87de6d0 into kubernetes:master Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 6, 2019

@Katharine: Updated the job-config configmap in namespace default using the following files:

  • key k8s-staging-cluster-api.yaml using file config/jobs/image-pushing/k8s-staging-cluster-api.yaml
Details

In response to this:

This adds a job for kubernetes-sigs/cluster-api to push images using some cloudbuild.yaml file in that repo.

/cc @Katharine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer mentioned this pull request Sep 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vincepri vincepri vincepri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vincepri vincepri

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.

3 participants

@Katharine @k8s-ci-robot @vincepri