-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unable to set memory in config #9789
Conversation
Signed-off-by: Tharun <[email protected]>
Welcome @tharun208! |
Hi @tharun208. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
/ok-to-test |
@tharun208 before merge, could you provide the output of the following with your change to ensure it works:
|
kvm2 Driver |
|
err = Set("memory", "10a") | ||
if err == nil || err.Error() != "run validations for \"memory\" with value of \"10a\": [invalid disk size: invalid size: '10a']" { | ||
t.Fatalf("Set did not return error for unallowed value: %+v", err) | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO the positive case should be tested too. Or may I've missed it in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this PR
@tharun208
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, priyawadhwa, tharun208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tharun [email protected]
This PR fixes the
config set memory
command which has invalidValidation
andSet
function which not allowed to set a valid memory value.Fixes #9769