Skip to content

Commit 3e670f2

Browse files
authored
Merge pull request #9789 from tharun208/fix/config_memory
fix unable to set memory in config
2 parents 4a0382f + 5b8670c commit 3e670f2

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

cmd/minikube/cmd/config/config.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ var settings = []Setting{
9292
},
9393
{
9494
name: "memory",
95-
set: SetInt,
96-
validations: []setFn{IsPositive},
95+
set: SetString,
96+
validations: []setFn{IsValidDiskSize},
9797
callbacks: []setFn{RequiresRestartMsg},
9898
},
9999
{

cmd/minikube/cmd/config/set_test.go

+4
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ func TestSetNotAllowed(t *testing.T) {
3838
if err == nil || err.Error() != "run validations for \"driver\" with value of \"123456\": [driver \"123456\" is not supported]" {
3939
t.Fatalf("Set did not return error for unallowed value: %+v", err)
4040
}
41+
err = Set("memory", "10a")
42+
if err == nil || err.Error() != "run validations for \"memory\" with value of \"10a\": [invalid disk size: invalid size: '10a']" {
43+
t.Fatalf("Set did not return error for unallowed value: %+v", err)
44+
}
4145
}
4246

4347
func TestSetOK(t *testing.T) {

0 commit comments

Comments
 (0)