Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube status should display InsufficientStorage status #9034

Merged
merged 16 commits into from
Aug 24, 2020

Commits on Aug 19, 2020

  1. Make sure 'minikube status' displays InsufficientStorage for cluster …

    …and nodes
    
    if there is insufficient storage. Output now looks like:
    
    ```
    {
      "Name": "minikube",
      "StatusCode": 507,
      "StatusName": "InsufficientStorage",
      "StatusDetail": "/var is almost out of disk space",
      "Step": "Starting Node",
      "StepDetail": "Updating the running docker \"minikube\" container ...",
      "BinaryVersion": "v1.12.3",
      "Components": {
        "kubeconfig": {
          "Name": "kubeconfig",
          "StatusCode": 500,
          "StatusName": ""
        }
      },
      "Nodes": [
        {
          "Name": "minikube",
          "StatusCode": 507,
          "StatusName": "InsufficientStorage",
          "Components": {
            "apiserver": {
              "Name": "apiserver",
              "StatusCode": 405,
              "StatusName": "Stopped"
            },
            "kubelet": {
              "Name": "kubelet",
              "StatusCode": 405,
              "StatusName": "Stopped"
            }
          }
        }
      ]
    }
    ```
    Priya Wadhwa committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    3dba974 View commit details
    Browse the repository at this point in the history
  2. Make sure minikube status shows status name and details

    Priya Wadhwa committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1783cc2 View commit details
    Browse the repository at this point in the history
  3. Add integration test for insufficient storage

    Make sure that if /var has full storage, the output of `minikube status` is correct regardless of whether events.json is present or not
    Priya Wadhwa committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    4d1c1c0 View commit details
    Browse the repository at this point in the history
  4. fix lint

    Priya Wadhwa committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    399dad0 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' of https://github.com/kubernetes/minikube into …

    …var-status-code
    Priya Wadhwa committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    e1ed864 View commit details
    Browse the repository at this point in the history
  6. improve output

    Priya Wadhwa committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    e1deec7 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. validate last event is the correct error

    Priya Wadhwa committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    3cb9026 View commit details
    Browse the repository at this point in the history
  2. add deubgging

    Priya Wadhwa committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    83eba00 View commit details
    Browse the repository at this point in the history
  3. Create new exit code for InsufficientStorage

    Priya Wadhwa committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7eda3a7 View commit details
    Browse the repository at this point in the history
  4. additional debugging

    Priya Wadhwa committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    482b2bf View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. write events to file, but not in parallel

    Priya Wadhwa committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    4fcffca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    44b93f4 View commit details
    Browse the repository at this point in the history
  3. Remove debugging

    Priya Wadhwa committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    acd6589 View commit details
    Browse the repository at this point in the history
  4. fix error wording

    Priya Wadhwa committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    97acf40 View commit details
    Browse the repository at this point in the history
  5. change name

    Priya Wadhwa committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    88aece4 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2020

  1. fix merge conflict

    Priya Wadhwa committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    a767b64 View commit details
    Browse the repository at this point in the history