minikube status should display InsufficientStorage status
#9034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 19, 2020 13:25
…and nodes
if there is insufficient storage. Output now looks like:
```
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"StatusDetail": "/var is almost out of disk space",
"Step": "Starting Node",
"StepDetail": "Updating the running docker \"minikube\" container ...",
"BinaryVersion": "v1.12.3",
"Components": {
"kubeconfig": {
"Name": "kubeconfig",
"StatusCode": 500,
"StatusName": ""
}
},
"Nodes": [
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"Components": {
"apiserver": {
"Name": "apiserver",
"StatusCode": 405,
"StatusName": "Stopped"
},
"kubelet": {
"Name": "kubelet",
"StatusCode": 405,
"StatusName": "Stopped"
}
}
}
]
}
```
Make sure that if /var has full storage, the output of `minikube status` is correct regardless of whether events.json is present or not
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Travis tests have failedHey @priyawadhwa, 1st Buildmake testTravisBuddy Request Identifier: 3d3c1860-e249-11ea-9f3b-59dd2f7037a2 |
|
kvm2 Driver Times for Minikube (PR 9034): [64.22037242900001 63.14525925 62.241870046] Averages Time Per Log docker Driver Times for Minikube (PR 9034): [26.590494290000002 28.599669192 27.115608858999998] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 9034): [63.040289963 60.350666024999995 60.547234507] Averages Time Per Log docker Driver Times for Minikube (PR 9034): [26.18993283 26.900492492 27.718564597999997] Averages Time Per Log |
added 2 commits
August 19, 2020 17:44
|
kvm2 Driver Times for Minikube (PR 9034): [60.49869067800001 61.89910126499999 60.440889600000006] Averages Time Per Log docker Driver Times for Minikube (PR 9034): [25.881243734999998 26.89222078 25.226766421] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 9034): [61.90289326 64.53189187100001 63.61634883400001] Averages Time Per Log docker Driver Times for Minikube (PR 9034): [25.36184817099999 26.733341119 27.495426960000003] Averages Time Per Log |
Travis tests have failedHey @priyawadhwa, 1st Buildmake testTravisBuddy Request Identifier: d1a521a0-e315-11ea-bb85-f7bf5149087f |
|
kvm2 Driver Times for Minikube (PR 9034): [63.190896916 65.792703035 62.32789936500001] Averages Time Per Log docker Driver Times for Minikube (PR 9034): [26.546051369 26.723791151 26.634963164000006] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 9034): [62.73075056199999 63.915660092 60.212209642999994] Averages Time Per Log docker Driver Times for Minikube (PR 9034): [26.49501921 25.880543957 26.369757498000002] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 9034): [56.794120537 61.904536532 62.422069537] Averages Time Per Log docker Driver Times for Minikube (PR 9034): [26.627061618000003 26.468240042999998 27.792748863] Averages Time Per Log |
priyawadhwa
force-pushed
the
var-status-code
branch
from
2c74cf2
to
482b2bf
Compare
|
kvm2 Driver Times for Minikube (PR 9034): [62.393888303 61.983090352999994 62.853965414] Averages Time Per Log docker Driver Times for Minikube (PR 9034): [27.621654498999995 27.077977619000002 26.155184218000002] Averages Time Per Log |
afbjorklund
previously requested changes
Aug 21, 2020
priyawadhwa
force-pushed
the
var-status-code
branch
from
c88619f
to
acd6589
Compare
Travis tests have failedHey @priyawadhwa, 1st Buildmake testTravisBuddy Request Identifier: 912beef0-e3b6-11ea-bb85-f7bf5149087f |
|
kvm2 Driver Times for Minikube (PR 9034): 62.8s 62.8s 62.7s Averages Time Per Log docker Driver Times for Minikube (PR 9034): 34.4s 25.7s 27.9s Averages Time Per Log |
medyagh
reviewed
Aug 21, 2020
|
kvm2 Driver Times for Minikube (PR 9034): 58.8s 62.9s 62.1s Averages Time Per Log docker Driver Times for Minikube (PR 9034): 25.3s 26.7s 25.4s Averages Time Per Log |
medyagh
requested changes
Aug 21, 2020
|
kvm2 Driver Times for Minikube (PR 9034): 63.4s 63.1s 66.2s Averages Time Per Log docker Driver Times for Minikube (PR 9034): 25.9s 26.9s 26.1s Averages Time Per Log |
medyagh
approved these changes
Aug 21, 2020
|
kvm2 Driver Times for Minikube (PR 9034): 63.9s 61.9s 63.3s Averages Time Per Log docker Driver Times for Minikube (PR 9034): 28.3s 27.3s 27.0s Averages Time Per Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
minikube statusdisplaying InsufficientStorage as its status if /var is almost at memory capacityThis PR also adds an integration test to make sure the output is correct
After this, the output of
minikube status --output json --layout clusterlooks like this:fixes #9025