Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling metrics addon when someone enables dashboard #8842

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

kadern0
Copy link
Contributor

@kadern0 kadern0 commented Jul 26, 2020

Signed-off-by: Pablo Caderno [email protected]

Fixes #8714

./out/minikube addons list
|-----------------------------|----------|--------------|
|         ADDON NAME          | PROFILE  |    STATUS    |
|-----------------------------|----------|--------------|
| ambassador                  | minikube | disabled     |
| dashboard                   | minikube | disabled     |
| default-storageclass        | minikube | enabled ✅   |
| efk                         | minikube | disabled     |
| freshpod                    | minikube | disabled     |
| gcp-auth                    | minikube | disabled     |
| gvisor                      | minikube | disabled     |
| helm-tiller                 | minikube | disabled     |
| ingress                     | minikube | disabled     |
| ingress-dns                 | minikube | disabled     |
| istio                       | minikube | disabled     |
| istio-provisioner           | minikube | disabled     |
| kubevirt                    | minikube | disabled     |
| logviewer                   | minikube | disabled     |
| metallb                     | minikube | disabled     |
| metrics-server              | minikube | disabled     |
| nvidia-driver-installer     | minikube | disabled     |
| nvidia-gpu-device-plugin    | minikube | disabled     |
| olm                         | minikube | disabled     |
| pod-security-policy         | minikube | disabled     |
| registry                    | minikube | disabled     |
| registry-aliases            | minikube | disabled     |
| registry-creds              | minikube | disabled     |
| storage-provisioner         | minikube | enabled ✅   |
| storage-provisioner-gluster | minikube | disabled     |
|-----------------------------|----------|--------------|
$ ./out/minikube addons enable dashboard
⌛  enabling metrics-server addon along with dashboard
🌟  The 'metrics-server' addon is enabled
🌟  The 'dashboard' addon is enabled
$ ./out/minikube addons list
|-----------------------------|----------|--------------|
|         ADDON NAME          | PROFILE  |    STATUS    |
|-----------------------------|----------|--------------|
| ambassador                  | minikube | disabled     |
| dashboard                   | minikube | enabled ✅   |
| default-storageclass        | minikube | enabled ✅   |
| efk                         | minikube | disabled     |
| freshpod                    | minikube | disabled     |
| gcp-auth                    | minikube | disabled     |
| gvisor                      | minikube | disabled     |
| helm-tiller                 | minikube | disabled     |
| ingress                     | minikube | disabled     |
| ingress-dns                 | minikube | disabled     |
| istio                       | minikube | disabled     |
| istio-provisioner           | minikube | disabled     |
| kubevirt                    | minikube | disabled     |
| logviewer                   | minikube | disabled     |
| metallb                     | minikube | disabled     |
| metrics-server              | minikube | enabled ✅   |
| nvidia-driver-installer     | minikube | disabled     |
| nvidia-gpu-device-plugin    | minikube | disabled     |
| olm                         | minikube | disabled     |
| pod-security-policy         | minikube | disabled     |
| registry                    | minikube | disabled     |
| registry-aliases            | minikube | disabled     |
| registry-creds              | minikube | disabled     |
| storage-provisioner         | minikube | enabled ✅   |
| storage-provisioner-gluster | minikube | disabled     |
|-----------------------------|----------|--------------|

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kadern0
To complete the pull request process, please assign josedonizetti
You can assign the PR to them by writing /assign @josedonizetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this

@TravisBuddy
Copy link

Travis tests have failed

Hey @kadern0,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="c30be236fb059ccb34d7a2cab1d1ae1928a0235b"" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading k8s.io/apimachinery v0.17.3
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/spf13/viper v1.7.0
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/otiai10/copy v1.0.2
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading k8s.io/api v0.17.3
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading k8s.io/kubernetes v1.17.3
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading google.golang.org/protobuf v1.24.0
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/imdario/mergo v0.3.9
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/google/gofuzz v1.0.0
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/beorn7/perks v1.0.1
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/prometheus/common v0.9.1
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: downloading k8s.io/kube-proxy v0.17.3
go: downloading k8s.io/kubelet v0.17.3
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading github.com/pmezard/go-difflib v1.0.0
ok  	k8s.io/minikube/cmd/minikube/cmd	56.632s	coverage: 19.7% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.156s	coverage: 21.3% of statements
E0726 03:35:34.704639   12038 out.go:141] [unset errFile]: * 
E0726 03:35:34.704843   12038 out.go:141] [unset errFile]: X Error getting primary control plane: remove /tmp/profile439276671/.minikube/profiles/config.json: no such file or directory
E0726 03:35:34.704857   12038 out.go:141] [unset errFile]: * 
E0726 03:35:34.704867   12038 out.go:141] [unset errFile]: * minikube is exiting due to an error. If the above message is not useful, open an issue:
E0726 03:35:34.704875   12038 out.go:141] [unset errFile]:   - https://github.com/kubernetes/minikube/issues/new/choose
FAIL	k8s.io/minikube/pkg/addons	0.038s
ok  	k8s.io/minikube/pkg/drivers	0.006s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.003s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.008s	coverage: 0.0% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.019s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.753s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.057s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.008s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.003s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.039s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.017s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.072s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.027s	coverage: 36.6% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.017s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.014s	coverage: 34.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.005s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.015s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.021s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.004s	coverage: 50.0% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.023s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.338s	coverage: 37.7% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.014s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.048s	coverage: 58.0% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.006s	coverage: 76.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.090s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.011s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.009s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.009s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.068s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.004s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.028s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.032s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.650s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.838s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.010s	coverage: 0.0% of statements
FAIL
Makefile:274: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: 47b2c5c0-cef1-11ea-9502-ed86ad10d0d8

cmd/minikube/cmd/config/enable.go Outdated Show resolved Hide resolved
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@TravisBuddy
Copy link

Travis tests have failed

Hey @kadern0,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="39815e3bb461cfaefae5b1bce2c9c01a7e39a9d6"" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading k8s.io/kubernetes v1.17.3
go: downloading k8s.io/apimachinery v0.17.3
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading k8s.io/api v0.17.3
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/spf13/cobra v1.0.0
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/docker/go-units v0.4.0
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/spf13/cast v1.3.1
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/google/gofuzz v1.0.0
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/google/uuid v1.1.1
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/json-iterator/go v1.1.9
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading google.golang.org/api v0.25.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/google/go-cmp v0.4.1
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading go.uber.org/multierr v1.1.0
go: downloading k8s.io/kubelet v0.17.3
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/fatih/color v1.9.0
go: downloading k8s.io/kube-proxy v0.17.3
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
ok  	k8s.io/minikube/cmd/minikube/cmd	4.019s	coverage: 19.7% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.158s	coverage: 21.3% of statements
E0726 22:40:56.336855   12474 out.go:141] [unset errFile]: * 
E0726 22:40:56.337153   12474 out.go:141] [unset errFile]: X Error getting primary control plane: remove /tmp/profile206223582/.minikube/profiles/config.json: no such file or directory
E0726 22:40:56.337208   12474 out.go:141] [unset errFile]: * 
E0726 22:40:56.337229   12474 out.go:141] [unset errFile]: * minikube is exiting due to an error. If the above message is not useful, open an issue:
E0726 22:40:56.337251   12474 out.go:141] [unset errFile]:   - https://github.com/kubernetes/minikube/issues/new/choose
FAIL	k8s.io/minikube/pkg/addons	0.127s
ok  	k8s.io/minikube/pkg/drivers	0.011s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.003s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.011s	coverage: 0.0% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.028s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.949s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.109s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.005s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.007s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.046s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.052s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.182s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.079s	coverage: 36.6% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.038s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.021s	coverage: 34.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.023s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.028s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.035s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.024s	coverage: 50.0% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.035s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.376s	coverage: 37.7% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.015s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.047s	coverage: 58.0% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.008s	coverage: 76.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.170s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.017s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.009s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.009s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.065s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.017s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.037s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.030s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.005s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.669s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.998s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.006s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.006s	coverage: 0.0% of statements
FAIL
Makefile:274: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: 50045450-cf91-11ea-9502-ed86ad10d0d8

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kadern0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable metric addon when someone enables dashboard
5 participants