-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling metrics addon when someone enables dashboard #8842
Conversation
Hi @kadern0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kadern0 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this
Travis tests have failedHey @kadern0, 1st Buildmake test
TravisBuddy Request Identifier: 47b2c5c0-cef1-11ea-9502-ed86ad10d0d8 |
Can one of the admins verify this patch? |
Travis tests have failedHey @kadern0, 1st Buildmake test
TravisBuddy Request Identifier: 50045450-cf91-11ea-9502-ed86ad10d0d8 |
Signed-off-by: Pablo Caderno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kadern0
Signed-off-by: Pablo Caderno [email protected]
Fixes #8714