Skip to content

Commit

Permalink
Merge pull request #8842 from kadern0/issue-8714
Browse files Browse the repository at this point in the history
Enabling metrics addon when someone enables dashboard
  • Loading branch information
medyagh authored Jul 27, 2020
2 parents d546ea1 + 8578e09 commit f53bea5
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions cmd/minikube/cmd/config/enable.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ var addonsEnableCmd = &cobra.Command{
if err != nil {
exit.WithError("enable failed", err)
}
if addon == "dashboard" {
out.T(out.Waiting, "Some dashboard features require the 'metrics-server' add-on")
err = addons.SetAndSave(ClusterFlagValue(), "metrics-server", "true")
if err != nil {
exit.WithError("enable failed", err)
}
out.T(out.AddonEnable, "The 'metrics-server' add-on was enabled automatically")
}

out.T(out.AddonEnable, "The '{{.addonName}}' addon is enabled", out.V{"addonName": addon})
},
}
Expand Down

0 comments on commit f53bea5

Please sign in to comment.