-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs which prevented upgrades from v1.0+ to v1.12 #8741
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 Driver |
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: 5511c500-c7d9-11ea-ab6f-3547fdb4f9a3 |
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: c3dba090-c7da-11ea-ab6f-3547fdb4f9a3 |
kvm2 Driver Times for Minikube (PR 8741): [64.46544553300001 61.04591257199999 67.607436357] Averages Time Per Log
docker Driver Times for Minikube (PR 8741): [27.186333945999998 24.786307352999994 25.45797803] Averages Time Per Log
|
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: 1454f080-c7f4-11ea-ab6f-3547fdb4f9a3 |
kvm2 Driver Times for Minikube (PR 8741): [64.800166037 63.75637571699999 63.952538167] Averages Time Per Log
docker Driver Times for Minikube (PR 8741): [26.047705659000002 26.329247827999996 25.888073077] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 8741): [59.274288339 62.83340330000001 63.253749327] Averages Time Per Log
docker Driver Times for Minikube (PR 8741): [24.919346797000003 26.670028803 26.552439665] Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, pending integration tests
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: 0c5aaf30-c850-11ea-8ad2-cd0863c1f5b3 |
kvm2 Driver Times for Minikube (PR 8741): [62.909318156000005 64.56984379500001 63.383608354] Averages Time Per Log
docker Driver Times for Minikube (PR 8741): [25.39144246 25.24434769 24.448585883] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 8741): [63.965903511 64.84103810799999 63.441705235] Averages Time Per Log
docker Driver Times for Minikube (PR 8741): [25.821001348 26.224065408 24.759466165] Averages Time Per Log
|
Fixes a couple of upgrade quirks I noticed during testing:
This also adds integration tests to assert that we can always upgrade from a stopped v1.0 cluster, or a newer running cluster.
There are likely other edge-cases provided by random command-line options, but this PR addresses the edge cases that affect most if not all users.