Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KicBaseImage to existing config if missing (fixes v1.9.x upgrade) #8738

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes docker: invalid reference format. which occurs in the following reproduction case:

minikube-1.9.2 start --driver=docker
docker stop minikube
docker rm minikube
minikube-1.12.0 start --driver=docker

For upgrades which require a container reset, we were inadvertently passing an empty cc.KicBaseImage to the resulting docker command-line.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from RA489 July 17, 2020 00:39
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2020
@tstromberg tstromberg changed the title Fix v1.9.x upgrade by populating missing KicBaseImage configuration Add KicBaseImage to existing config if missing (fixes v1.9.x upgrade) Jul 17, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [64.547466277 62.189983981000005 63.374132552999995]
Average time for minikube: 63.370527603666666

Times for Minikube (PR 8738): [62.089197214 65.106288707 66.44759319]
Average time for Minikube (PR 8738): 64.547693037

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8738) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.0 on Debian   |  0.055167 |           0.052590 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018224 |           0.016868 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.011111 |           0.003014 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.030379 |          40.933682 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.776249 |          22.073946 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.276552 |           1.240337 |
| components...                  |           |                    |
| * Enabled addons:              |  0.130624 |           0.144866 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.067499 |           0.078716 |
| configured to use "minikube"   |           |                    |
|                                |  0.004722 |           0.003674 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [24.16624929 25.709493386999995 25.306907223000003]
Average time for minikube: 25.0608833

Times for Minikube (PR 8738): [25.881317466 25.489330815 26.087785244]
Average time for Minikube (PR 8738): 25.819477841666668

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8738) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.0 on Debian   |  0.063713 |           0.064685 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.002428 |           0.002383 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.056115 |           0.053643 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  7.243021 |           7.336470 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 16.677051 |          17.338955 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  0.785938 |           0.862108 |
| components...                  |           |                    |
| * Enabled addons:              |  0.167356 |           0.097080 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.061894 |           0.061149 |
| configured to use "minikube"   |           |                    |
|                                |  0.003367 |           0.003005 |
+--------------------------------+-----------+--------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants