-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KicBaseImage to existing config if missing (fixes v1.9.x upgrade) #8738
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 Driver |
kvm2 Driver Times for Minikube (PR 8738): [62.089197214 65.106288707 66.44759319] Averages Time Per Log
docker Driver Times for Minikube (PR 8738): [25.881317466 25.489330815 26.087785244] Averages Time Per Log
|
Fixes
docker: invalid reference format.
which occurs in the following reproduction case:For upgrades which require a container reset, we were inadvertently passing an empty cc.KicBaseImage to the resulting docker command-line.