docker/podman: warn if allocated memory is below limit #8718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Travis tests have failedHey @medyagh, 1st Buildmake testTravisBuddy Request Identifier: daaed0c0-c565-11ea-af19-3b271fec1f42 |
|
this PR made this windows integration machine be revlead I had forgotten to increase the memory in one of the windows CI machines. |
tstromberg
suggested changes
Jul 14, 2020
k8s-ci-robot
added
size/L
tstromberg
suggested changes
Jul 15, 2020
| @@ -813,12 +817,28 @@ func validateMemorySize() { | |||
| out.T(out.Notice, "Requested memory allocation ({{.requested}}MB) is less than the recommended minimum {{.recommended}}MB. Kubernetes may crash unexpectedly.", | |||
| out.V{"requested": req, "recommended": minRecommendedMem}) | |||
| } | |||
|
|
|||
| if driver.IsDockerDesktop(drvName) { | |||
| if containerLimit < 1991 { | |||
There was a problem hiding this comment.
Can this re-use minRecommendedMem?
There was a problem hiding this comment.
docker info for when it is 2 GB:
Total Memory: 1.945GiB
Travis tests have failedHey @medyagh, 1st Buildmake testTravisBuddy Request Identifier: d2d87b60-c6e3-11ea-aa06-e17841301e13 |
tstromberg
changed the title
tstromberg
approved these changes
Jul 15, 2020
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver |
|
kvm2 Driver Times for Minikube (PR 8718): [62.627652054999984 62.970327809000004 63.356936265] Averages Time Per Log docker Driver |
|
kvm2 Driver Times for Minikube (PR 8718): [62.971556731999996 64.296524759 64.17082851699999] Averages Time Per Log docker Driver |
|
kvm2 Driver Times for Minikube (PR 8718): [62.65889518600001 62.251427324999995 61.837026172] Averages Time Per Log docker Driver |
|
kvm2 Driver Times for Minikube (PR 8718): [64.11718042499999 63.489435939 65.06925279200001] Averages Time Per Log docker Driver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8540 and #7980
1
Before This PR setting memory Memory=50000000MB
After this PR setting memory to higher than what is available:
2
Before this PR with less than 2 GB memory in docker desktop
(goes un-detected)
After this PR with less than 2 GB memory in docker desktop
3
Suggest user to increase docker desktop memory if user has at least 8 GB system memory
After this PR
4 CPU
Before this PR with 1 CPU in docker
After this PR with a docker desktop with only 1 CPUs