-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error handling for validating memory limits #8959
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @medyagh, 1st Buildmake test
2nd Buildmake test
3rd Buildmake
TravisBuddy Request Identifier: 5cbb6e50-db52-11ea-bc40-19e33457b5db |
babcf51
to
e0bee98
Compare
c83910e
to
059891b
Compare
Travis tests have failedHey @medyagh, 1st Buildmake test
2nd Buildmake test
3rd Buildmake
TravisBuddy Request Identifier: 3766c060-dbf6-11ea-9ba8-b569b15b137c |
7dd048e
to
7463eda
Compare
/ok-to-test |
kvm2 Driver Times for Minikube (PR 8959): [63.899230526 60.756932453000005 63.552269857] Averages Time Per Log
docker Driver Times for Minikube (PR 8959): [27.398135560000004 25.950301275999994 25.945593018999997] Averages Time Per Log
|
side effect of this #8877
might help with weird flakes like this #8958
most notably, do NOT return -1 if there is CPU or Disk Info Error.