-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Move docker root dir outside of /var and mount preload to that instead #8509
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @priyawadhwa, 1st Buildmake test
TravisBuddy Request Identifier: 8952f5a0-b0eb-11ea-b9a3-b9754cbad7e4 |
/ok-to-test |
kvm2 Driver Times for Minikube (PR 8509): [66.572457082 63.923166309 66.775475646] Averages Time Per Log
docker Driver Times for Minikube (PR 8509): [24.906386167999997 26.33537339900001 26.719124001999997] Averages Time Per Log
|
Hi @priyawadhwa I'm not sure I like using My preferred approach was to handle the container image in the same was as we already do with the VM. That is, to use one mount for the disk image. And then do bind mounts to this shared location. We would need some kind of "minikube-automount" service for this though, so that it happens automatically. |
I think this could potentially fix #8179 and #8163
Still looking into it