-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the persistent storage actually survive reboots #8151
Comments
Suggestion is to add a compatibility symlink, for the existing docker/podman volumes:
And then move the content down a level, before doing so. Same with "tmp" and "logs".
|
The other stuff in the current volume, we don't have to care about:
Most of it is empty anyway.
|
I might have missed some stuff above, like "containerd" and "boot2docker". Imagine those there. |
We also discussed this briefly for the "none" driver, in the #7511 issue about the mountpoint. |
symlink could work ! |
Hello! Not sure if this is the same issue. My setup:
I have a PV, provisioned by minikube-hostpath:
As you can see from the provisioned host path, the third one is still used. Looking at the mount table in the minikube container, I can only see /tmp being mounted as a Should my use-case for "docker-desktop+minikube start --driver=docker" be covered by this issue? |
Yeah, maybe it was the second one that is gone ? Let's persist both of them. |
I think we will leave the /var volume as-is, since it comes from the KIC image. We probably don't want to use: But maybe that is the easiest ? (I don't really believe in using /var/tmp for this) At any point, we need to make an automount service for the kicbase image. mkdir -p /mnt/$PARTNAME/data
mkdir /data
mount --bind /mnt/$PARTNAME/data /data
mkdir -p /mnt/$PARTNAME/hostpath_pv
mkdir /tmp/hostpath_pv
mount --bind /mnt/$PARTNAME/hostpath_pv /tmp/hostpath_pv
mkdir -p /mnt/$PARTNAME/hostpath-provisioner
mkdir /tmp/hostpath-provisioner
mount --bind /mnt/$PARTNAME/hostpath-provisioner /tmp/hostpath-provisioner The "/mnt/$PARTNAME" will need to be replaced with "/var" (or a subdirectory) |
For the KIC (and for "none"), we need to make sure that the persistant directories are preserved:
https://minikube.sigs.k8s.io/docs/handbook/persistent_volumes/
These are persisted today:
(the third one is for crio, and for podman)
These also need to be kept:
(I don't think the third one is used anymore)
We can put them on the docker/podman volume, and at least mention them in the "none" docs...
They are normally bind mounts, to some place that is persistent (like disk image or docker volume)
A nice change to go with this one, would be to stop volume mounting all of
/var
(at the top level).Because it conflicts with existing paths, in the ubuntu image. Like
/var/lib/dpkg/alternatives
.See #8056 and #8100
The kicbase doesn't boot without it.
The text was updated successfully, but these errors were encountered: