Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Fix StartStopTest/group/containerd flake … #7969

Closed
wants to merge 4 commits into from

Commits on Apr 30, 2020

  1. Fix StartStopTest/group/containerd flake

    This test was failing regularly with the following error showing up on all pods:
    
    ```
    FailedCreatePodSandbox
    ```
    
    after doing some digging, it seems that this error is always CNI related. I found these docs on the k8s website about running containerd in minikube:
    
    https://kubernetes.io/docs/setup/learning-environment/minikube/
    
    which says the flags `--network-plugin=cni` and `--enable-default-cni` should be set with running containerd. I tried passing those flags in, and ran this test locally 3x. It passed everytime, so I'm hoping this fixes the flake.
    Priya Wadhwa committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    0f1db84 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Pass is pod subnet arg

    Also, the dashboard addon wasn't being enabled because of this flow:
    
    ```
    minikube stop
    minikube addons enable dashboard
    minikube start
    ```
    
    but on start, dashboard was skipped because it seemed like it had already been enabled.
    Priya Wadhwa committed May 1, 2020
    Configuration menu
    Copy the full SHA
    471c85d View commit details
    Browse the repository at this point in the history
  2. Fix log

    Priya Wadhwa committed May 1, 2020
    Configuration menu
    Copy the full SHA
    47bbee1 View commit details
    Browse the repository at this point in the history
  3. fix lint

    Priya Wadhwa committed May 1, 2020
    Configuration menu
    Copy the full SHA
    27811f4 View commit details
    Browse the repository at this point in the history