wip: Fix StartStopTest/group/containerd flake … #7969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 30, 2020 14:54
This test was failing regularly with the following error showing up on all pods: ``` FailedCreatePodSandbox ``` after doing some digging, it seems that this error is always CNI related. I found these docs on the k8s website about running containerd in minikube: https://kubernetes.io/docs/setup/learning-environment/minikube/ which says the flags `--network-plugin=cni` and `--enable-default-cni` should be set with running containerd. I tried passing those flags in, and ran this test locally 3x. It passed everytime, so I'm hoping this fixes the flake.
Also, the dashboard addon wasn't being enabled because of this flow: ``` minikube stop minikube addons enable dashboard minikube start ``` but on start, dashboard was skipped because it seemed like it had already been enabled.
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #7969 +/- ##
==========================================
- Coverage 36.06% 35.94% -0.13%
==========================================
Files 144 144
Lines 9191 9204 +13
==========================================
- Hits 3315 3308 -7
- Misses 5475 5497 +22
+ Partials 401 399 -2
|
|
kvm2 Driver Times for Minikube (PR 7969): [63.594053806 66.225509132 68.282022962] Averages Time Per Log docker Driver Times for Minikube (PR 7969): [26.27470847 27.049298984 28.288583654999996] Averages Time Per Log |
priyawadhwa
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing regularly with the following error showing up on all pods:
after doing some digging, it seems that this error is always CNI related. I found these docs on the k8s website about running containerd in minikube:
https://kubernetes.io/docs/setup/learning-environment/minikube/
which says the flags
--network-plugin=cniand--enable-default-cnishould be set with running containerd. I tried passing those flags in, and a flag for pod subnet.This test was then failing because the kubernetes dashboard addon would never come up.
The dashboard addon wasn't being enabled because of this flow:
but on start, dashboard was skipped because it seemed like it had already been enabled.
I refactored addons code to always enable addons on
minikube start, and to only check if they've already been enabled onminikube addons enable/disable xxxShould fix #7704