-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow ingress addon for docker/podman drivers only on linux for now #7393
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Error: running mkcmp: exit status 1 |
Codecov Report
@@ Coverage Diff @@
## master #7393 +/- ##
==========================================
- Coverage 37.16% 37.14% -0.03%
==========================================
Files 146 146
Lines 8838 8844 +6
==========================================
Hits 3285 3285
- Misses 5165 5170 +5
- Partials 388 389 +1
|
All Times Minikube (PR 7393): [ 62.167569 65.501514 64.078250] Average minikube: 63.442080 Averages Time Per Log
|
I had the same issue using minikube and docker driver on my Mac. I deleted the docker profile and used the virtual box driver. All worked.
|
Will ingress + docker be supported in the future? Thanks! |
does not close #7332 but it will at least provide a better message.
after this PR:
also add docs to the website
meanwhile we will work on implementing this feature for mac an windows.