Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ingress addon for docker/podman drivers only on linux for now #7393

Merged
merged 5 commits into from
Apr 3, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Apr 3, 2020

does not close #7332 but it will at least provide a better message.

after this PR:

💡  Due to docker networking limitations on darwin, ingress addon is not supported for this driver.
Alternatively to use this addon you can use a vm-based driver:

        'minikube start --vm=true'

To track the update on this work in progress feature please check:
https://github.com/kubernetes/minikube/issues/7332```

also add docs to the website

meanwhile we will work on implementing this feature for mac an windows.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2020
@medyagh
Copy link
Member Author

medyagh commented Apr 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 3, 2020
@medyagh medyagh changed the title dont allow enabling ingress addon for docker on mac and windows allow ingress addon for docker/podman drivers only on linux till solved Apr 3, 2020
@medyagh medyagh changed the title allow ingress addon for docker/podman drivers only on linux till solved allow ingress addon for docker/podman drivers only on linux for now Apr 3, 2020
pkg/addons/addons.go Outdated Show resolved Hide resolved
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #7393 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7393      +/-   ##
==========================================
- Coverage   37.16%   37.14%   -0.03%     
==========================================
  Files         146      146              
  Lines        8838     8844       +6     
==========================================
  Hits         3285     3285              
- Misses       5165     5170       +5     
- Partials      388      389       +1     
Impacted Files Coverage Δ
pkg/addons/addons.go 43.60% <0.00%> (-1.58%) ⬇️

@minikube-pr-bot
Copy link

All Times Minikube (PR 7393): [ 62.167569 65.501514 64.078250]
All Times minikube: [ 62.892773 62.894432 64.539034]

Average minikube: 63.442080
Average Minikube (PR 7393): 63.915778

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7393) |
+----------------------+-----------+--------------------+
| minikube v           |  0.220317 |           0.213715 |
| Creating kvm2        | 39.824513 |          40.382699 |
| Preparing Kubernetes | 21.841580 |          21.643365 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit 825a6e8 into kubernetes:master Apr 3, 2020
@medyagh medyagh deleted the ingress_addon_mac branch April 3, 2020 02:47
@reneli5
Copy link

reneli5 commented Jul 4, 2020

I had the same issue using minikube and docker driver on my Mac. I deleted the docker profile and used the virtual box driver. All worked.
Here is how:

  1. minikube delete
  2. minikube start --vm-driver virtualbox
  3. minikube addons enable ingress

@fzyzcjy
Copy link

fzyzcjy commented Aug 9, 2020

Will ingress + docker be supported in the future? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker: Ingress not exposed on MacOS
7 participants