Skip to content

Commit

Permalink
Merge pull request #7393 from medyagh/ingress_addon_mac
Browse files Browse the repository at this point in the history
allow ingress addon for docker/podman drivers only on linux for now
  • Loading branch information
medyagh authored Apr 3, 2020
2 parents d8747ae + 3f16f27 commit 825a6e8
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
12 changes: 12 additions & 0 deletions pkg/addons/addons.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package addons
import (
"fmt"
"path"
"runtime"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -122,6 +123,17 @@ func enableOrDisableAddon(cc *config.ClusterConfig, name string, val string) err
}
}

// to match both ingress and ingress-dns adons
if strings.HasPrefix(name, "ingress") && enable && driver.IsKIC(cc.Driver) && runtime.GOOS != "linux" {
exit.UsageT(`Due to {{.driver_name}} networking limitations on {{.os_name}}, {{.addon_name}} addon is not supported for this driver.
Alternatively to use this addon you can use a vm-based driver:
'minikube start --vm=true'
To track the update on this work in progress feature please check:
https://github.com/kubernetes/minikube/issues/7332`, out.V{"driver_name": cc.Driver, "os_name": runtime.GOOS, "addon_name": name})
}

if strings.HasPrefix(name, "istio") && enable {
minMem := 8192
minCPUs := 4
Expand Down
5 changes: 5 additions & 0 deletions site/content/en/docs/Reference/Drivers/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,9 @@ The Docker driver is the newest minikube driver. which runs kubernetes in contai
- Cross platform (linux, macos, windows)
- No hypervisor required when run on Linux.

## Known Issues.

- The 'ingress' and 'ingress-dns' addons are only supported on Linux.
these addons are not supported for Docker Driver on MacOS and Windows yet. to get updates on the work in progress please check [issue page](https://github.com/kubernetes/minikube/issues/7332)

- a known [docker issue for MacOs](https://github.com/docker/for-mac/issues/1835), a containers on Docker on MacOS might hang and get stuck while other containers can get created. The current workaround is restarting docker.

0 comments on commit 825a6e8

Please sign in to comment.