Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make certificates per-profile and consistent until IP or names change #7125

Merged
merged 4 commits into from
Mar 21, 2020

Conversation

tstromberg
Copy link
Contributor

This avoids the bug where we unnecessarily crash a running apiserver by reprovisioning its certificates.

This speeds up "minikube start" on a running cluster substantially, because components no longer go into CrashLoopBackOff due to certificate changes.

Fixes #7102 and #5353

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 20, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@codecov-io
Copy link

codecov-io commented Mar 21, 2020

Codecov Report

Merging #7125 into master will increase coverage by 0.08%.
The diff coverage is 67.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7125      +/-   ##
==========================================
+ Coverage   36.96%   37.05%   +0.08%     
==========================================
  Files         145      145              
  Lines        9165     9208      +43     
==========================================
+ Hits         3388     3412      +24     
- Misses       5359     5374      +15     
- Partials      418      422       +4     
Impacted Files Coverage Δ
pkg/minikube/localpath/localpath.go 15.15% <0.00%> (-2.09%) ⬇️
pkg/minikube/bootstrapper/certs.go 73.41% <73.19%> (-0.48%) ⬇️
pkg/minikube/machine/delete.go 44.11% <0.00%> (-1.34%) ⬇️

@minikube-pr-bot
Copy link

All Times Minikube (PR 7125): [ 68.207810 67.670353 67.352638]
All Times minikube: [ 65.631224 64.619664 68.702739]

Average minikube: 66.317876
Average Minikube (PR 7125): 67.743600

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7125) |
+----------------------+-----------+--------------------+
| minikube v           |  0.235347 |           0.217478 |
| Creating kvm2        | 42.340425 |          42.071736 |
| Preparing Kubernetes | 21.646332 |           1.761152 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |          21.469769 |
| Waiting for cluster  |  0.413117 |           0.244648 |
+----------------------+-----------+--------------------+

@tstromberg
Copy link
Contributor Author

Looks like a recent commit to this broke kubeconfig. Will investigate.

@minikube-pr-bot
Copy link

All Times minikube: [ 68.000250 67.388954 68.541432]
All Times Minikube (PR 7125): [ 71.048715 71.694202 71.342800]

Average minikube: 67.976879
Average Minikube (PR 7125): 71.361906

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7125) |
+----------------------+-----------+--------------------+
| minikube v           |  0.263949 |           0.224058 |
| Creating kvm2        | 43.484742 |          43.741031 |
| Preparing Kubernetes | 22.073953 |          24.910341 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |  0.263157 |           0.585847 |
+----------------------+-----------+--------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker: reusing running container -> bind: address already in use
5 participants