-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make certificates per-profile and consistent until IP or names change #7125
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Error: running mkcmp: exit status 1 |
Codecov Report
@@ Coverage Diff @@
## master #7125 +/- ##
==========================================
+ Coverage 36.96% 37.05% +0.08%
==========================================
Files 145 145
Lines 9165 9208 +43
==========================================
+ Hits 3388 3412 +24
- Misses 5359 5374 +15
- Partials 418 422 +4
|
All Times Minikube (PR 7125): [ 68.207810 67.670353 67.352638] Average minikube: 66.317876 Averages Time Per Log
|
Looks like a recent commit to this broke kubeconfig. Will investigate. |
All Times minikube: [ 68.000250 67.388954 68.541432] Average minikube: 67.976879 Averages Time Per Log
|
This avoids the bug where we unnecessarily crash a running apiserver by reprovisioning its certificates.
This speeds up "minikube start" on a running cluster substantially, because components no longer go into CrashLoopBackOff due to certificate changes.
Fixes #7102 and #5353