-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--embed-certs=true in v1.9.0: client.crt: The system cannot find the file specified. #7293
Comments
Sorry about that. I believe you are correct, that this is likely is an unintended consequence of #7125 - It seems like there are no integration tests for We should definitely fix the last of tests before marking this issue as closed, otherwise it will be broken again in the future. |
Hi @tstromberg yeah, I took a look at #7125 but I can't find my way around Go well enough to track it down. Also ... thats an easy workaround untill this is tracked down and fixed. |
@Larswa - to be honest, I wrote this PR, and I still don't understand how the --embed-certs feature ever worked. The two packages seem to have a very loose coupling with one another, so I assume it just worked via implicit assumptions. Your hint is very useful though, as it leads me to believe that the assumption may have been in the order-of-operations. Tracking the issue down will take a bit of local testing and likely a few new log messages. Likely just a one-liner to fix. Thank you for bringing it to our attention! |
I guess this problem exists already since a bit longer but only shows now, see e.g. with a fresh v1.4.0:
I guess it worked for you back then because there were some certificate inside of |
@tstromberg Thanks for making me feel a litle less stupid. 😂 @linkvt I think this has been working in earlier version as I have had a script for a couple of months, running a |
@Larswa just try it with deleting the /assign linkvt |
Hey @linkvt Thanks. The easiest workaround I found was to run |
@Larswa - if you want to try a Windows binary built from linkvt's PR: https://storage.googleapis.com/minikube-builds/7309/minikube-windows-amd64.exe Having confirmation would be useful. |
@tstromberg @linkvt I can confirm that it worked! Very cool! I removed existing minkube instance, removed the .minikube folder in my user profile and did a |
Whoops .. dunno if this should have been closed already without linking it to the pr. |
Thank you @Larswa for the confirmation! This issue will auto-merge once the PR is merged. |
This is a new bug in 1.9.0. Earlier versions did not exhibit this behavior.
I get this failure when producing a new minikube instance with the --embed-certs=true param/value.
If I run this command to get the full cert in the kubeconfig on an existing minikube instance it works just fine, and I get the cert written into my kube config file.
I suspect this could be related to #7125 ?
The exact command to reproduce the issue:
Run this to create a new Minikube instance:
minikube start --embed-certs=true
The full output of the command that failed:
The output of the
minikube logs
command:The operating system version:
Windows 10 Pro 10.0.19041 Build 19041
The text was updated successfully, but these errors were encountered: