Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kic: fix unprivileged port bind tunnel docker for mac #6833

Merged
merged 2 commits into from
Feb 28, 2020
Merged

kic: fix unprivileged port bind tunnel docker for mac #6833

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77fbafb
kic: fix unprivileged port bind tunnel docker for mac
josedonizetti Feb 28, 2020
11c0612
kic: only ask sudo for privileged ports tunnel docker for mac
josedonizetti Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/minikube/tunnel/kic/ssh_conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func createSSHConn(name, sshPort, sshKey string, svc *v1.Service) *sshConn {
// extract sshArgs
sshArgs := []string{
// TODO: document the options here
"ssh",
"-o", "UserKnownHostsFile=/dev/null",
"-o", "StrictHostKeyChecking no",
"-N",
Expand All @@ -55,7 +56,7 @@ func createSSHConn(name, sshPort, sshKey string, svc *v1.Service) *sshConn {
sshArgs = append(sshArgs, arg)
}

cmd := exec.Command("ssh", sshArgs...)
cmd := exec.Command("sudo", sshArgs...)

return &sshConn{
name: name,
Expand Down