Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kic: fix unprivileged port bind tunnel docker for mac #6833

Merged
merged 2 commits into from
Feb 28, 2020
Merged

kic: fix unprivileged port bind tunnel docker for mac #6833

merged 2 commits into from
Feb 28, 2020

Conversation

josedonizetti
Copy link
Member

@josedonizetti josedonizetti commented Feb 28, 2020 •
edited
Loading

Fix for #6832

If any service exposes privileged ports, we print a message informing the user which service/port and ask sudo permission.

minikube tunnel
The service nginx-svc requires priviledged ports to be exposed: [80]
sudo permission will be asked for it.

This PR also fixes the functional test for tunnel, it now passes for docker on osx too. https://github.com/kubernetes/minikube/blob/master/test/integration/fn_tunnel_cmd.go

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josedonizetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2020
@medyagh
Copy link
Member

medyagh commented Feb 28, 2020

looks good thank you for this !

@medyagh medyagh merged commit 83dd0db into kubernetes:master Feb 28, 2020
@josedonizetti josedonizetti deleted the kic-fix-unprivileged-port-bind branch February 28, 2020 21:56
@tstromberg tstromberg mentioned this pull request Sep 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josedonizetti @k8s-ci-robot @medyagh