Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip driver autodetection if driver is already set #6503

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Feb 5, 2020

On my MacBook Pro, this PR:

The only negative is that if the user has already specifically chosen a driver, we no longer show the alternatives possible.

UI change

Old:

✨ Automatically selected the 'hyperkit' driver (alternates: [virtualbox vmwarefusion docker])

New:

✨ Automatically selected the hyperkit driver. Other choices: virtualbox, vmwarefusion, docker (experimental)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 5, 2020
@tstromberg tstromberg changed the title Skip driver autodetect if driver is already set Skip driver autodetection if driver is already set Feb 5, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 97.757348 97.367846 99.023391]
All Times Minikube (PR 6503): [ 95.805546 95.752421 97.685391]

Average minikube: 98.049528
Average Minikube (PR 6503): 96.414453

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6503) |
+----------------------+-----------+--------------------+
| minikube v           |  0.331484 |           0.191947 |
| Creating kvm2        | 20.202903 |          19.878649 |
| Preparing Kubernetes | 49.760967 |          49.793520 |
| Pulling images       |  3.670698 |           3.628442 |
| Launching Kubernetes | 20.013350 |          19.667306 |
| Waiting for cluster  |  1.405134 |           1.222890 |
+----------------------+-----------+--------------------+

@sharifelgamal
Copy link
Collaborator

sharifelgamal commented Feb 5, 2020

This change LGTM, just needs to fix a lint error:

pkg/minikube/cluster/start.go:189: File is not `goimports`-ed (goimports)
  if driver.BareMetal(h.Driver.DriverName()) {

@minikube-pr-bot
Copy link

All Times minikube: [ 98.342826 99.801661 95.513690]
All Times Minikube (PR 6503): [ 97.358634 95.628702 98.990637]

Average minikube: 97.886059
Average Minikube (PR 6503): 97.325991

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6503) |
+----------------------+-----------+--------------------+
| minikube v           |  0.320863 |           0.195026 |
| Creating kvm2        | 19.813383 |          20.058561 |
| Preparing Kubernetes | 50.225235 |          50.922649 |
| Pulling images       |  4.193392 |           3.423215 |
| Launching Kubernetes | 20.095195 |          19.831940 |
| Waiting for cluster  |  1.224473 |           1.057923 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 2ecc120 into kubernetes:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestFunctional/parallel/DryRun: exit code = -1, wanted = 78: signal: killed
4 participants