-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip driver autodetection if driver is already set #6503
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
All Times minikube: [ 97.757348 97.367846 99.023391] Average minikube: 98.049528 Averages Time Per Log
|
This change LGTM, just needs to fix a lint error:
|
All Times minikube: [ 98.342826 99.801661 95.513690] Average minikube: 97.886059 Averages Time Per Log
|
On my MacBook Pro, this PR:
--dry-run
by ~9.5X (fixes TestFunctional/parallel/DryRun: exit code = -1, wanted = 78: signal: killed #6364)The only negative is that if the user has already specifically chosen a driver, we no longer show the alternatives possible.
UI change
Old:
✨ Automatically selected the 'hyperkit' driver (alternates: [virtualbox vmwarefusion docker])
New:
✨ Automatically selected the hyperkit driver. Other choices: virtualbox, vmwarefusion, docker (experimental)