Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestFunctional/parallel/DryRun: exit code = -1, wanted = 78: signal: killed #6364

Closed
medyagh opened this issue Jan 22, 2020 · 3 comments · Fixed by #6503 or #7482
Closed

TestFunctional/parallel/DryRun: exit code = -1, wanted = 78: signal: killed #6364

medyagh opened this issue Jan 22, 2020 · 3 comments · Fixed by #6503 or #7482
Assignees
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@medyagh
Copy link
Member

medyagh commented Jan 22, 2020

I believe the dry run returns a different exist code on kvm for some reason !
as seen in https://storage.googleapis.com/minikube-builds/logs/6338/KVM_Linux.html#failtestwindow5

=== RUN   TestFunctional/parallel/DryRun
=== PAUSE TestFunctional/parallel/DryRun
=== CONT  TestFunctional/parallel/DryRun
--- FAIL: TestFunctional/parallel/DryRun (3.07s)
functional_test.go:313: (dbg) Run:  out/minikube-linux-amd64 start -p functional-20200121T174445.238510036-4853 --dry-run --memory 250MB --vm-driver=kvm2 
functional_test.go:313: (dbg) Non-zero exit: out/minikube-linux-amd64 start -p functional-20200121T174445.238510036-4853 --dry-run --memory 250MB --vm-driver=kvm2 : signal: killed (2.001806296s)
-- stdout --
* [functional-20200121T174445.238510036-4853] minikube v1.7.0-beta.0 on Debian 9.11
- KUBECONFIG=/home/jenkins/minikube-integration/linux-amd64-kvm2-6338-2439-5a3c13815ed5bb198a92b2183d9542af4462ddb3/kubeconfig
- MINIKUBE_BIN=out/minikube-linux-amd64
- MINIKUBE_HOME=/home/jenkins/minikube-integration/linux-amd64-kvm2-6338-2439-5a3c13815ed5bb198a92b2183d9542af4462ddb3/.minikube
- MINIKUBE_LOCATION=6338
-- /stdout --
functional_test.go:317: dry-run(250MB) exit code = -1, wanted = 78: signal: killed
functional_test.go:324: (dbg) Run:  out/minikube-linux-amd64 start -p functional-20200121T174445.238510036-4853 --dry-run --vm-driver=kvm2 
functional_test.go:324: (dbg) Done: out/minikube-linux-amd64 start -p functional-20200121T174445.238510036-4853 --dry-run --vm-driver=kvm2 : (1.071343365s)

but not seen in same test for vbox https://storage.googleapis.com/minikube-builds/logs/6338/VirtualBox_Linux.html

@medyagh medyagh added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jan 22, 2020
@medyagh
Copy link
Member Author

medyagh commented Jan 22, 2020

@tstromberg

@tstromberg
Copy link
Contributor

It sounds like it ran out of the strict time limit (2s). On my machine it takes 2s. I'll add some logging.

@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 22, 2020
@tstromberg tstromberg added this to the v1.8.0 milestone Feb 5, 2020
@tstromberg tstromberg reopened this Apr 7, 2020
@tstromberg tstromberg changed the title Test Dry run fails on kvm TestFunctional/parallel/DryRun: exit code = -1, wanted = 78: signal: killed Apr 7, 2020
@tstromberg
Copy link
Contributor

https://storage.googleapis.com/minikube-builds/logs/7389/eb42d16/KVM_Linux.html

--- FAIL: TestFunctional/parallel/DryRun (11.55s)
functional_test.go:387: (dbg) Run:  out/minikube-linux-amd64 start -p functional-20200406T171223.163798203-5853 --dry-run --memory 250MB --alsologtostderr -v=1 --driver=kvm2 
functional_test.go:387: (dbg) Non-zero exit: out/minikube-linux-amd64 start -p functional-20200406T171223.163798203-5853 --dry-run --memory 250MB --alsologtostderr -v=1 --driver=kvm2 : signal: killed (5.125049473s)
** stderr ** 
	I0406 17:22:00.826966   13399 notify.go:125] Checking for updates...
	I0406 17:22:02.464601   13399 start.go:262] hostinfo: {"hostname":"kvm-integration-slave6","uptime":3863,"bootTime":1586215059,"procs":269,"os":"linux","platform":"debian","platformFamily":"debian","platformVersion":"9.12","kernelVersion":"4.9.0-12-amd64","virtualizationSystem":"kvm","virtualizationRole":"host","hostid":"ae41e7f6-8b8e-4d40-b77d-1ebb5a2d5fdb"}
	I0406 17:22:02.465621   13399 start.go:272] virtualization: kvm host
** /stderr **
functional_test.go:391: dry-run(250MB) exit code = -1, wanted = 78: signal: killed
functional_test.go:398: (dbg) Run:  out/minikube-linux-amd64 start -p functional-20200406T171223.163798203-5853 --dry-run --alsologtostderr -v=1 --driver=kvm2 
functional_test.go:398: (dbg) Non-zero exit: out/minikube-linux-amd64 start -p functional-20200406T171223.163798203-5853 --dry-run --alsologtostderr -v=1 --driver=kvm2 : signal: killed (5.80576278s)
** stderr ** 
	I0406 17:22:06.747915   13413 notify.go:125] Checking for updates...
** /stderr **
functional_test.go:400: dry-run exit code = -1, wanted = 0: signal: killed

The root cause appears to be that we are checking for updates in dry-run mode. Sometimes that check takes a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
2 participants