-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable istio provisioner by default #6272
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6272 +/- ##
==========================================
- Coverage 38.28% 38.21% -0.07%
==========================================
Files 124 123 -1
Lines 8257 8255 -2
==========================================
- Hits 3161 3155 -6
- Misses 4686 4690 +4
Partials 410 410
|
Travis tests have failedHey @medyagh, TravisBuddy Request Identifier: 55ff2800-33f9-11ea-b5a3-65565334105f |
/ok-to-test |
All Times minikube: [ 125.045939 127.768756 126.033683] Average minikube: 126.282792 Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good, but some typos in the documentation
Fix http link to https link for security, modify many link http to https in the project. Signed-off-by: Nguyen Hai Truong <[email protected]>
All Times minikube: [ 110.479317 125.777875 123.730573] Average minikube: 119.995921 Averages Time Per Log
|
@medya: please rebase, there’s like a dozen unrelated commits here ? |
closing in favor of #6315 |
as side effect of istio addon PR, the istio provisioner was enabled by default.
closes #6271