Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable istio provisioner by default #6272

Closed
wants to merge 14 commits into from

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jan 10, 2020

as side effect of istio addon PR, the istio provisioner was enabled by default.
closes #6271

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #6272 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6272      +/-   ##
==========================================
- Coverage   38.28%   38.21%   -0.07%     
==========================================
  Files         124      123       -1     
  Lines        8257     8255       -2     
==========================================
- Hits         3161     3155       -6     
- Misses       4686     4690       +4     
  Partials      410      410
Impacted Files Coverage Δ
cmd/minikube/cmd/config/profile_list.go 4.1% <ø> (ø) ⬆️
pkg/addons/addons.go 28.18% <ø> (ø) ⬆️
pkg/minikube/assets/addons.go 37.93% <ø> (ø) ⬆️
pkg/minikube/config/config.go 56.66% <ø> (ø) ⬆️
pkg/minikube/driver/driver.go 78.46% <0%> (-3.8%) ⬇️
cmd/minikube/cmd/config/addons_list.go 11.76% <0%> (-12.05%) ⬇️
pkg/minikube/bootstrapper/bootstrapper.go 0% <0%> (ø) ⬆️
cmd/minikube/cmd/start.go 21.99% <0%> (-0.05%) ⬇️
pkg/minikube/out/style.go 91.66% <0%> (ø) ⬆️

@TravisBuddy
Copy link

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 55ff2800-33f9-11ea-b5a3-65565334105f

@medyagh
Copy link
Member Author

medyagh commented Jan 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 10, 2020
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 125.045939 127.768756 126.033683]
All Times Minikube (PR 6272): [ 125.748428 130.206022 126.507110]

Average minikube: 126.282792
Average Minikube (PR 6272): 127.487186

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6272) |
+----------------------+-----------+--------------------+
| minikube v           |  0.426152 |           0.428816 |
| Creating kvm2        | 47.949609 |          48.288132 |
| Preparing Kubernetes | 50.703214 |          51.272628 |
| Pulling images       |  3.386735 |           3.816653 |
| Launching Kubernetes | 21.043362 |          20.712417 |
| Waiting for cluster  |  2.726856 |           2.922363 |
| Done                 |           |                    |
|                      |  0.045176 |           0.045841 |
+----------------------+-----------+--------------------+

Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good, but some typos in the documentation

deploy/addons/istio/README.md Outdated Show resolved Hide resolved
deploy/addons/istio/README.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2020
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 110.479317 125.777875 123.730573]
All Times Minikube (PR 6272): [ 122.807261 122.653593 122.875092]

Average minikube: 119.995921
Average Minikube (PR 6272): 122.778649

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6272) |
+----------------------+-----------+--------------------+
| minikube v           |  0.300463 |           0.292043 |
| Creating kvm2        | 46.155901 |          45.839767 |
| Preparing Kubernetes | 48.448020 |          50.709116 |
| Pulling images       |  2.966846 |           2.840341 |
| Launching Kubernetes | 19.359838 |          20.463187 |
| Waiting for cluster  |  2.714718 |           2.583730 |
| Done                 |           |                    |
|                      |  0.050135 |           0.050464 |
+----------------------+-----------+--------------------+

@afbjorklund
Copy link
Collaborator

@medya: please rebase, there’s like a dozen unrelated commits here ?

@medyagh
Copy link
Member Author

medyagh commented Jan 14, 2020

closing in favor of #6315

@medyagh medyagh closed this Jan 14, 2020
@medyagh medyagh deleted the istio_add branch May 2, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

istio operator addon is enabled by default !
7 participants