Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istio operator addon is enabled by default ! #6271

Closed
medyagh opened this issue Jan 10, 2020 · 4 comments
Closed

istio operator addon is enabled by default ! #6271

medyagh opened this issue Jan 10, 2020 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@medyagh
Copy link
Member

medyagh commented Jan 10, 2020

I noticed since we merged the istio addon, users get an istio operator by default

NAMESPACE        NAME                               READY   STATUS              RESTARTS   AGE
istio-operator   istio-operator-5488b4489d-4hf82    0/1     ContainerCreating   0          19s
kube-system      coredns-6955765f44-fdvqn           0/1     ContainerCreating   0          21s
kube-system      coredns-6955765f44-tvbtq           0/1     ContainerCreating   0          21s
kube-system      etcd-minikube                      1/1     Running             0          6s
kube-system      kube-addon-manager-minikube        1/1     Running             0          6s
kube-system      kube-apiserver-minikube            1/1     Running             0          6s
kube-system      kube-controller-manager-minikube   1/1     Running             0          6s
kube-system      kube-proxy-w45wj                   1/1     Running             0          21s
kube-system      kube-scheduler-minikube            1/1     Running             0          6s
kube-system      storage-provisioner                0/1     ContainerCreating   0          19s
$ ./out/minikube addons list | grep enable
- addon-manager: enabled
- dashboard: enabled
- default-storageclass: enabled
- istio-provisioner: enabled
- storage-provisioner: enabled

CC: @fenglixa could this behavior be avoided?

@medyagh medyagh added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. labels Jan 10, 2020
@afbjorklund
Copy link
Collaborator

Duplicate of #6262

@afbjorklund afbjorklund marked this as a duplicate of #6262 Jan 11, 2020
@afbjorklund afbjorklund added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Jan 12, 2020
@fenglixa
Copy link
Contributor

@medyagh , yes, it's the behavior as my design, the reason of istio-provisioner is enabled by default:

  1. Enable/disable istio addon is based on istio-provisioner
  2. KUBECTL_EXTRA_PRUNE_WHITELIST need to add into addon-manager to ensure istio could be enabled successfully, that will lead to we need to install related crd during minikube deployed.

@afbjorklund
Copy link
Collaborator

You will have to come up with some other way of doing this, it should not be deployed by default.

@fenglixa
Copy link
Contributor

Sure, It's high priority to me, to make it works well, and also align with the product requirements.
I saw already a PR provided, will involve into it as well.

BR
-Feng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants