Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild docker images for each release #6235

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes #6146

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #6235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6235   +/-   ##
======================================
  Coverage    38.5%   38.5%           
======================================
  Files         122     122           
  Lines        8145    8145           
======================================
  Hits         3136    3136           
  Misses       4600    4600           
  Partials      409     409

@tstromberg tstromberg merged commit 03bec81 into kubernetes:master Jan 8, 2020
@afbjorklund
Copy link
Collaborator

The problem here seems to have been that it rebuilds the docker images for minikube versions ?

And not just when the versions (or contents) of the images change. So it might replace the existing...

GVISOR_IMAGE_VERSION ?= 2

STORAGE_PROVISIONER_TAG := v1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build new image for gvisor addon as part of each release
5 participants