Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build new image for gvisor addon as part of each release #6146

Closed
wmuizelaar opened this issue Dec 21, 2019 · 3 comments · Fixed by #6235
Closed

Build new image for gvisor addon as part of each release #6146

wmuizelaar opened this issue Dec 21, 2019 · 3 comments · Fixed by #6235
Assignees
@tstromberg
Labels
addon/gvisor kind/process Process oriented issues, like setting up CI

Comments

@wmuizelaar
Copy link
Contributor

Recently #6000 was merged to allow a new gvisor version to be used with the addon.

This was released with v1.16.0, but the image that containts the addon was never rebuilt, as the latest date shown on gcr.io/k8s-minikube/gvisor-addon is still 26 Oct 2019.

What is needed to get a new image being pushed to the registry?
@tstromberg tstromberg added addon/gvisor kind/bug Categorizes issue or PR as related to a bug. labels Jan 8, 2020
@tstromberg
Copy link
Contributor

I've pushed a new build manually by running:

make push-gvisor-addon-image

Clearly we do a bad job of remembering to this by hand. I'll send a PR out shortly that adds this to the automated release process.

@tstromberg tstromberg mentioned this issue Jan 8, 2020
Merged
@tstromberg tstromberg changed the title Build new image for gvisor addon Build new image for gvisor addon as part of each release Jan 8, 2020
@tstromberg
Copy link
Contributor

Thank you for bringing this to our attention!

@tstromberg tstromberg added kind/process Process oriented issues, like setting up CI and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 8, 2020
@tstromberg tstromberg self-assigned this Jan 8, 2020
@afbjorklund
Copy link
Collaborator

This will rebuild the image using the same GVISOR_IMAGE_VERSION

This might mean we end up with multiple images with the same tag.

But as long as either will work, I guess it is OK.

"Increment when there are breaking changes."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstromberg tstromberg

Labels
addon/gvisor kind/process Process oriented issues, like setting up CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rebuild docker images for each release tstromberg/minikube
3 participants
@tstromberg @wmuizelaar @afbjorklund