Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version number output of runc #6209

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

afbjorklund
Copy link
Collaborator

Current output:

runc version commit: d736ef14f0288d6993a1845745d6756cfc9ddd5a
spec: 1.0.1-dev

Expected output:

runc version 1.0.0-rc9
commit: d736ef14f0288d6993a1845745d6756cfc9ddd5a
spec: 1.0.1-dev

First noted in #5823

This makes for instance docker info miss the commit information:

 Runtimes: runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: b34a5c8af56e510852c35414db4c1f4fa6172339
 runc version: 
 init version: fec3683

And it makes it harder to tell which version that the commit refers to.


In general we should prefer using provided build script, rather than reinventing them.

So call make instead of go build, avoids having to duplicate linker flags and such...

And make the build more standardized, use the make target
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #6209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6209   +/-   ##
=======================================
  Coverage   38.35%   38.35%           
=======================================
  Files         120      120           
  Lines        8103     8103           
=======================================
  Hits         3108     3108           
  Misses       4591     4591           
  Partials      404      404

@medyagh medyagh merged commit 4dd8498 into kubernetes:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants