-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent naming of packages #5823
Comments
We have now updated to newer versions: conmon runc But the "-master" arguments above still hold. |
Due to this way of building, our runc also lacks a proper version:
While it is supposed to look like this:
It is making docker confused (about the version number). |
See also #5822, maybe we shouldn't use binaries for cni/cni-plugins and crictl - even if we do now ? For docker and containerd we can continue to use binaries, those are a pain to build from the sources. |
Well, apparently you need to rename packages if you want to use a newer version than system... Buildroot 2019.02
|
I guess changing from the "go build" hack back to the Makefile, would also fix the version. VERSION := ${shell cat ./VERSION}
runc: $(SOURCES)
$(GO) build -buildmode=pie $(EXTRA_FLAGS) -ldflags "-X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXT
RA_LDFLAGS)" -tags "$(BUILDTAGS)" -o runc .
Or at least make sure to add the VERSION and |
Think this is OK now, it's mainly containerd-bin/crio-bin and runc-master that are still "wrong". |
There aren't so many rules for naming buildroot packages, but some common ones are:
Package names that end in
-bin
don't really build from source code, but download a binaryPackage names that end in
-master
don't build a released version, but from master branch.The current minikube packages (for buildroot) are a historic mix of these, and should be aligned.
automount
cni-bin
cni-plugins-bin
conmon-master : this is now releasing regularly, we currently use
v0.3.0
containerd-bin : building this from source
crictl-bin
crio-bin : building this from source
docker-bin
gluster
hyperv-daemons
podman
runc-master : this is also non-releasing regularly, we use
v1.0.0-rc8
vbox-guest
The text was updated successfully, but these errors were encountered: