Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming of packages #5823

Closed
afbjorklund opened this issue Nov 3, 2019 · 6 comments
Closed

Consistent naming of packages #5823

afbjorklund opened this issue Nov 3, 2019 · 6 comments
Assignees
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@afbjorklund
Copy link
Collaborator

There aren't so many rules for naming buildroot packages, but some common ones are:

  • Package names that end in -bin don't really build from source code, but download a binary

  • Package names that end in -master don't build a released version, but from master branch.

The current minikube packages (for buildroot) are a historic mix of these, and should be aligned.


automount
cni-bin
cni-plugins-bin
conmon-master : this is now releasing regularly, we currently use v0.3.0
containerd-bin : building this from source
crictl-bin
crio-bin : building this from source
docker-bin
gluster
hyperv-daemons
podman
runc-master : this is also non-releasing regularly, we use v1.0.0-rc8
vbox-guest

@afbjorklund afbjorklund added area/guest-vm General configuration issues with the minikube guest VM priority/backlog Higher priority than priority/awaiting-more-evidence. labels Nov 3, 2019
@tstromberg tstromberg added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 6, 2019
@afbjorklund
Copy link
Collaborator Author

We have now updated to newer versions:

conmon v2.0.3

runc v1.0.0-rc9

But the "-master" arguments above still hold.

@afbjorklund
Copy link
Collaborator Author

Due to this way of building, our runc also lacks a proper version:

runc version commit: d736ef14f0288d6993a1845745d6756cfc9ddd5a
spec: 1.0.1-dev

While it is supposed to look like this:

runc version 1.0.0-rc9
commit: d736ef14f0288d6993a1845745d6756cfc9ddd5a
spec: 1.0.1-dev

It is making docker confused (about the version number).

@afbjorklund afbjorklund self-assigned this Nov 27, 2019
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Nov 27, 2019

See also #5822, maybe we shouldn't use binaries for cni/cni-plugins and crictl - even if we do now ?

For docker and containerd we can continue to use binaries, those are a pain to build from the sources.

@afbjorklund
Copy link
Collaborator Author

Well, apparently you need to rename packages if you want to use a newer version than system...

Buildroot 2019.02

@afbjorklund
Copy link
Collaborator Author

I guess changing from the "go build" hack back to the Makefile, would also fix the version.

VERSION := ${shell cat ./VERSION}

runc: $(SOURCES)
	$(GO) build -buildmode=pie $(EXTRA_FLAGS) -ldflags "-X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXT
RA_LDFLAGS)" -tags "$(BUILDTAGS)" -o runc .

Or at least make sure to add the VERSION and -X main.version=${VERSION} to runc

@afbjorklund
Copy link
Collaborator Author

Think this is OK now, it's mainly containerd-bin/crio-bin and runc-master that are still "wrong".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

2 participants