Add istio addon for minikube

[fenglixa]

fixes #3597

Usage and UT as below:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fenglixa
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fenglixa]

/cc @priyawadhwa

[codecov-io]

Codecov Report

Merging #6154 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6154      +/-   ##
==========================================
- Coverage   38.38%   38.35%   -0.04%     
==========================================
  Files         120      120              
  Lines        8096     8103       +7     
==========================================
  Hits         3108     3108              
- Misses       4585     4591       +6     
- Partials      403      404       +1

Impacted Files	Coverage Δ
pkg/minikube/assets/addons.go	36.66% <ø> (ø)	⬆️
cmd/minikube/cmd/config/config.go	10.41% <ø> (ø)	⬆️
cmd/minikube/cmd/config/util.go	32.63% <0%> (-1.67%)	⬇️

[medyagh]

Does the istio addon works with default 2000mb memory?

[medyagh]

/ok-to-test

[minikube-bot]

Error: running mkcmp: exit status 1

[fenglixa]

Does the istio addon works with default 2000mb memory?

Thanks @medyagh
Yes, it works under my testing for default minikube assigned mem/cpus, the istio profile I used is default, which is not fully istio components installed (e.g grafana is not installed with default profile)
for detail istio profile defination, could be refer to istio docs here:
https://istio.io/docs/setup/additional-setup/config-profiles/

[medyagh]

@fenglixa it would be usefull to warn the user that this addon needs more memory !
( in the screenshot I see a few of the pods are erroring, ... how did u test functionality of it )

[fenglixa]

@medyagh Thanks for your review, as your suggestion, I added mem&cpus detect and warning message in the code, the error is because my home network issue. : ) After switch the network, it's OK now, as below UT picture with warn message together. Any other comments?

[medyagh]

@fenglixa that is really good ! I am okay with merging this. would you like to add a page in the website about using this addon ? maybe with a very simple example ? would you like to do that in this PR or in the follow up PR ?

[fenglixa]

@fenglixa that is really good ! I am okay with merging this. would you like to add a page in the website about using this addon ? maybe with a very simple example ? would you like to do that in this PR or in the follow up PR ?

@medyagh , I added the document page for istio.

[medyagh]

@fenglixa thanks for adding docs. Maybe also include a link to istios main documentation.

And also a small comment I added

[medyagh]

Also the link on the website preview for istio is broken

Here if u click on istio
https://deploy-preview-6154--kubernetes-sigs-minikube.netlify.com/docs/tasks/addons/

https://deploy-preview-6154--kubernetes-sigs-minikube.netlify.com/istio/readme

[fenglixa]

https://deploy-preview-6154--kubernetes-sigs-minikube.netlify.com/docs/tasks/addons/
https://deploy-preview-6154--kubernetes-sigs-minikube.netlify.com/istio/readme

@medyagh the link is OK now.

[medyagh]

@fenglixa thank you for this contribution.