Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Istio addon #3597

Closed
wstrange opened this issue Jan 28, 2019 · 16 comments · Fixed by #6154
Closed

Feature Request: Istio addon #3597

wstrange opened this issue Jan 28, 2019 · 16 comments · Fixed by #6154
Assignees
@fenglixa
Labels
area/addons good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. r/2019q2 Issue was last reviewed 2019q2

Comments

@wstrange
Copy link

FEATURE REQUEST

Istio is becoming very popular for it's service mesh and ingress features. It is now available on GKE as a managed service. It would be a really nice addon for minikube.
@tstromberg
Copy link
Contributor

I too would love to see this happen. Any volunteers out there?

"Adding an addon" documentation: https://github.com/kubernetes/minikube/blob/master/docs/contributors/adding_an_addon.md

@tstromberg tstromberg added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. area/addons good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 28, 2019
@himani93
Copy link

Hi, can I work on this as my first contribution to minikube. Thanks

@tstromberg
Copy link
Contributor

tstromberg commented Jan 30, 2019 •
edited
Loading

@himani93 excellent! Please let me know if there is anything I can do to help.

FYI - I'd mark this issue as assigned to you, but something is getting in the way with my GitHub permissions. Please feel free to make it happen anyways!

@ashishranjan738
Copy link

@himani93 are you working on it i was thinking to give it a try ? cc @tstromberg

@himani93
Copy link

himani93 commented Feb 4, 2019

@ashishranjan738 I am working on it. @wstrange can you please assign the issue?

@wstrange
Copy link
Author

wstrange commented Feb 4, 2019 •
edited
Loading

I am not a minikube maintainer, I don't think I can assign issues?

@gbraad
Copy link
Contributor

gbraad commented Feb 4, 2019 via email

@balopat
Copy link
Contributor

balopat commented Feb 5, 2019

/assign @himani93

@k8s-ci-robot
Copy link
Contributor

@balopat: GitHub didn't allow me to assign the following users: himani93.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @himani93

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tstromberg tstromberg added the r/2019q2 Issue was last reviewed 2019q2 label Apr 4, 2019
@fenglixa
Copy link
Contributor

@himani93 are you still working on this? I would like to provide PR for this ticket. Thanks
BR
-Francis

@himani93
Copy link

@fenglixa Sure, please go ahead.

@medyagh
Copy link
Member

medyagh commented Aug 14, 2019

@fenglixa are you still working on this ?

@fenglixa
Copy link
Contributor

OK, I will try this recently. @medyagh , do you have any deadline for this ticket?
Have investigated before, the effort to support istio on minikube is not as simply as my original thought.
-Feng

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2019
@tstromberg tstromberg added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2019
@priyawadhwa
Copy link

@fenglixa are you still interested in adding support for Istio? If so, I can assign you to this issue, and am happy to look at any PRs or help in any way.

@fenglixa
Copy link
Contributor

/assign

@fenglixa fenglixa mentioned this issue Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fenglixa fenglixa

Labels
area/addons good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. r/2019q2 Issue was last reviewed 2019q2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add istio addon for minikube fenglixa/minikube