-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for "stable" and "latest"aliases for --kubernetes-version #6142
Conversation
Welcome @ths-laurent! |
Hi @ths-laurent. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ths-laurent The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6142 +/- ##
==========================================
- Coverage 38.29% 38.27% -0.02%
==========================================
Files 119 119
Lines 8077 8081 +4
==========================================
Hits 3093 3093
- Misses 4581 4583 +2
- Partials 403 405 +2
|
/ok-to-test |
Error: running mkcmp: exit status 1 |
All Times minikube: [ 112.716941 115.992934 113.660741] Average minikube: 114.123539 Averages Time Per Log
|
@@ -68,7 +68,7 @@ var DefaultISOSHAURL = DefaultISOURL + SHASuffix | |||
var DefaultKubernetesVersion = "v1.17.0" | |||
|
|||
// NewestKubernetesVersion is the newest Kubernetes version to test against | |||
var NewestKubernetesVersion = "v1.17.0" | |||
var NewestKubernetesVersion = "v1.18.0-alpha.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind removing the part of your PR that updates Newest to v1.18? I feel like the PR is doing too much. Otherwise, I think it's good to go.
Hey @ths-laurent, this PR is pretty close to merging! Are you still working on it? I'd love to get it merged, so if you are, please:
and we can get this in! |
@ths-laurent: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
any hope for a rebase? |
I'm going to close this for now since it's been stale for a while. Please reopen once the conflicts are resolved. |
Added the check for the aliases.
In the issue's comment it was mentioned that the constant NewestKubernetesVersion should be 1.18.0-alpha.1 (now it is 1.17.0). I don't know if it was part of this issue so I left it unchanged.
Related to #6126