-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --kubernetes-version=(latest|stable) aliases #6126
Comments
I see versions defined in minikube/pkg/minikube/constants/constants.go Lines 67 to 74 in b6ff7ba
default , newest , and oldest . Did I miss stable ? I'm guessing as of this writing, stable would be 1.16.4 and latest would be 1.18.0-alpha.1 (Mirroring https://github.com/kubernetes/kubernetes/releases). Is this right?
|
Default is stable. Newest should be updated to v1.18.0-alpha.1. |
/assign |
@ths-laurent - sounds great! Feel free to ask here for any clarifications necessary to implement this feature. :) |
Thanks :). At first I wasn't sure if the NewestKubernetesVersion constant had to be updated but re-reading the comments helped clarifying that. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Seems that the user deleted his account, the PR had also no activity despite it seems to be fixed. /assign |
/remove-lifecycle stale |
/assign |
As proposed by @robrich in #6122
As I mentioned there, minikube does not yet support
latest
or stableversion aliases, but it would be trivial to add. If you or anyone else is interested in making this work, add a check for
paramVersion == "stable"` here:minikube/cmd/minikube/cmd/start.go
Line 1127 in 56c72e2
We currently store the stable and latest versions as constants that you can refer to.
The text was updated successfully, but these errors were encountered: