Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --kubernetes-version=(latest|stable) aliases #6126

Closed
tstromberg opened this issue Dec 19, 2019 · 9 comments · Fixed by #7212
Closed

Add support for --kubernetes-version=(latest|stable) aliases #6126

tstromberg opened this issue Dec 19, 2019 · 9 comments · Fixed by #7212
Assignees
Labels
area/kubernetes-versions Improving support for versions of Kubernetes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@tstromberg
Copy link
Contributor

As proposed by @robrich in #6122

As I mentioned there, minikube does not yet support latest or stableversion aliases, but it would be trivial to add. If you or anyone else is interested in making this work, add a check forparamVersion == "stable"` here:

if paramVersion == "" { // if the user did not specify any version then ...

We currently store the stable and latest versions as constants that you can refer to.

@tstromberg tstromberg added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 19, 2019
@tstromberg tstromberg changed the title Add support for --kubernetes-version=(latest|stable) alias Add support for --kubernetes-version=(latest|stable) aliases Dec 19, 2019
@tstromberg tstromberg added area/kubernetes-versions Improving support for versions of Kubernetes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Dec 19, 2019
@robrich
Copy link
Contributor

robrich commented Dec 19, 2019

I see versions defined in

// DefaultKubernetesVersion is the default kubernetes version
var DefaultKubernetesVersion = "v1.17.0"
// NewestKubernetesVersion is the newest Kubernetes version to test against
var NewestKubernetesVersion = "v1.17.0"
// OldestKubernetesVersion is the oldest Kubernetes version to test against
var OldestKubernetesVersion = "v1.11.10"
but it's default, newest, and oldest. Did I miss stable? I'm guessing as of this writing, stable would be 1.16.4 and latest would be 1.18.0-alpha.1 (Mirroring https://github.com/kubernetes/kubernetes/releases). Is this right?

@tstromberg
Copy link
Contributor Author

Default is stable.

Newest should be updated to v1.18.0-alpha.1.

@ghost
Copy link

ghost commented Dec 20, 2019

/assign
Hi, I would like to work on that one

@k8s-ci-robot k8s-ci-robot assigned ghost Dec 20, 2019
@tstromberg
Copy link
Contributor Author

@ths-laurent - sounds great! Feel free to ask here for any clarifications necessary to implement this feature. :)

@ghost
Copy link

ghost commented Dec 21, 2019

Thanks :). At first I wasn't sure if the NewestKubernetesVersion constant had to be updated but re-reading the comments helped clarifying that.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2020
@linkvt
Copy link
Contributor

linkvt commented Mar 24, 2020

Seems that the user deleted his account, the PR had also no activity despite it seems to be fixed. /assign

@linkvt
Copy link
Contributor

linkvt commented Mar 24, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 24, 2020
@linkvt
Copy link
Contributor

linkvt commented Mar 24, 2020

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes-versions Improving support for versions of Kubernetes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants